Skip to content

[wasm][debugger] Never send messages from our internal protocol extensions to the browser #77616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaystg merged 4 commits into from
Oct 31, 2022
Merged

[wasm][debugger] Never send messages from our internal protocol extensions to the browser #77616

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79988a2
ignore messages from protocol extensions even for unknown context
thaystg Oct 28, 2022
0d1f7ef
Addressing @radical comments
thaystg Oct 28, 2022
cb3d9bb
adressing @radical comments
thaystg Oct 28, 2022
13ff9bc
adressing @radical comments
thaystg Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adressing @radical comments
  • Loading branch information
@thaystg
thaystg authored Oct 28, 2022
commit cb3d9bba272ce9a9e14e1a7d4d4728e861beeac8
8 changes: 2 additions & 6 deletions src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,9 +268,7 @@ protected override async Task<bool> AcceptCommand(MessageId id, JObject parms, C
_defaultPauseOnExceptions = pauseOnException;
}
// don't pass through DotnetDebugger.* messages to the browser
if (method.StartsWith("DotnetDebugger.", StringComparison.Ordinal))
return true;
return false;
return method.StartsWith("DotnetDebugger.", StringComparison.OrdinalIgnoreCase);
}

switch (method)
Expand Down Expand Up @@ -570,9 +568,7 @@ protected override async Task<bool> AcceptCommand(MessageId id, JObject parms, C
}
}
// don't pass through DotnetDebugger.* messages to the browser
if (method.StartsWith("DotnetDebugger.", StringComparison.Ordinal))
return true;
return false;
return method.StartsWith("DotnetDebugger.", StringComparison.OrdinalIgnoreCase);
}

private async Task<bool> ApplyUpdates(MessageId id, JObject args, CancellationToken token)
Expand Down