Skip to content

[PERF][Release/7.0] Update release/7.0 Perf infrastructure to use Perf repo release/7.0 branch #77699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 7 commits into from
Nov 3, 2022
Merged

[PERF][Release/7.0] Update release/7.0 Perf infrastructure to use Perf repo release/7.0 branch #77699

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
42bd9fd
Update perf branch to clone to release/7.0 from main.
LoopedBard3 Oct 31, 2022
5b34fb0
Setup testing.
LoopedBard3 Oct 31, 2022
8b66246
Fix SOD and Startup builds for performance.
LoopedBard3 Oct 26, 2022
acd0492
[PERF] Pass local runtime timestamp from git into ci_setup (#76396)
LoopedBard3 Oct 3, 2022
bd6aee4
Updated the Nuget feed to fix net6.0 maui run and moved .net version …
LoopedBard3 Nov 1, 2022
9e79920
Switch back to using the release/7.0 perf branch.
LoopedBard3 Nov 1, 2022
0cca6c4
Remove user from pip3 install for musl.
LoopedBard3 Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Switch back to using the release/7.0 perf branch.
  • Loading branch information
@LoopedBard3
LoopedBard3 committed Nov 1, 2022
commit 9e799204610b95fb276ff96c6c1a413c4e79b8e4
2 changes: 1 addition & 1 deletion eng/testing/performance/performance-setup.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ if ($RunFromPerformanceRepo) {
robocopy $SourceDirectory $PerformanceDirectory /E /XD $PayloadDirectory $SourceDirectory\artifacts $SourceDirectory\.git
}
else {
git clone --branch FixPerfRelease/7.0 --depth 1 --quiet https://github.com/LoopedBard3/performance $PerformanceDirectory
git clone --branch release/7.0 --depth 1 --quiet https://github.com/dotnet/performance $PerformanceDirectory
}

if($MonoDotnet -ne "")
Expand Down
2 changes: 1 addition & 1 deletion eng/testing/performance/performance-setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ else
if [[ -n "$perf_fork" ]]; then
git clone --branch $perf_fork_branch --depth 1 --quiet $perf_fork $performance_directory
else
git clone --branch FixPerfRelease/7.0 --depth 1 --quiet https://github.com/LoopedBard3/performance.git $performance_directory
git clone --branch release/7.0 --depth 1 --quiet https://github.com/dotnet/performance.git $performance_directory
Copy link
Member

@hoyosjs hoyosjs Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a future thing, do you think it's worth using the build agent variables here?

Copy link
Member Author

@LoopedBard3 LoopedBard3 Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do the build agent variables get set/added from? I like the idea, and it may be worth making something in this area that will use the variable if it is properly available. At the very least, it is worthwhile to look into it.

Copy link
Member Author

@LoopedBard3 LoopedBard3 Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is a good Doc link to make sure I am thinking of the correct thing when you say build agent variable would be great.

Copy link
Member

@hoyosjs hoyosjs Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://learn.microsoft.com/en-us/azure/devops/pipelines/build/variables?view=azure-devops&tabs=yaml, particularly something like Build.SourceBranchName if this doesn't run on PRs, and use System.PullRequest.TargetBranch for PRs, that way you don't have to patch when branching.

fi
# uncomment to use BenchmarkDotNet sources instead of nuget packages
# git clone https://github.com/dotnet/BenchmarkDotNet.git $benchmark_directory
Expand Down