Skip to content

Fix bug with BigInteger.TrailingZeroCount #77727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannergooding merged 7 commits into from
Nov 10, 2022
Merged

Fix bug with BigInteger.TrailingZeroCount #77727

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
52e8e0a
Fix bug with BigInteger.TrailingZeroCount
dakersnar Nov 1, 2022
adfd872
Update src/libraries/System.Runtime.Numerics/tests/BigIntegerTests.Ge…
dakersnar Nov 1, 2022
365ea26
Update negative code path
dakersnar Nov 1, 2022
4b59220
Simplify logic for handling negative values
dakersnar Nov 2, 2022
652efed
Update src/libraries/System.Runtime.Numerics/src/System/Numerics/BigI…
dakersnar Nov 2, 2022
94c95d7
Update comment
dakersnar Nov 2, 2022
d6a4cd2
Merge branch 'fix-77720' of https://github.com/dakersnar/runtime into…
dakersnar Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update comment
  • Loading branch information
@dakersnar
dakersnar committed Nov 2, 2022
commit 94c95d7defdfc59dcc808f64e9ebdcb11c16135e
5 changes: 2 additions & 3 deletions src/libraries/System.Runtime.Numerics/src/System/Numerics/BigInteger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3481,9 +3481,8 @@ public static BigInteger TrailingZeroCount(BigInteger value)

ulong result = 0;

// As explained in https://github.com/dotnet/runtime/issues/77720, both positive values and
// their two's-compliment negative representation will share the same TrailingZeroCount,
// so the stored sign of value does not matter
// Both positive values and their two's-compliment negative representation will share the same TrailingZeroCount,
// so the stored sign of value does not matter and both cases can be handled in the same way

uint part = value._bits[0];

Expand Down