Skip to content

Add simple Else conditions to If Conversion #77728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 23 commits into from
Nov 30, 2022
Merged

Add simple Else conditions to If Conversion #77728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
d954180
Add simple Else conditions to If Conversion
a74nh Oct 7, 2022
548dc4c
Move phase and stop updating ssa
a74nh Nov 2, 2022
5edc966
Wrap JitConfig access
a74nh Nov 2, 2022
507cb1c
Add GT_RETURN else cases
a74nh Nov 3, 2022
1159d44
Add test cases with verification checks
a74nh Nov 3, 2022
9c83324
Ensure single only operation condition checks are used
a74nh Nov 7, 2022
b9cebb0
Merge main
a74nh Nov 7, 2022
f857358
Remove empty line
a74nh Nov 7, 2022
8e2c43f
Use DOTNET_ instead of COMPlus_
a74nh Nov 9, 2022
00505d2
Move JitDoIfConversion check
a74nh Nov 9, 2022
9ec7f71
Move if conversion into it's own file
a74nh Nov 14, 2022
779cbfd
Always invert condition
a74nh Nov 14, 2022
e6b2d1b
Rename IfConvertMergeBlocks
a74nh Nov 14, 2022
cd4b580
Use gtGetOp1()
a74nh Nov 14, 2022
b96a719
Merge branch main
a74nh Nov 14, 2022
e1c2f7e
Expand tests
a74nh Nov 14, 2022
4ef54d4
Merge branch main
a74nh Nov 14, 2022
1a0927f
Merge branch main
a74nh Nov 14, 2022
3a659e2
Add operation type assert
a74nh Nov 15, 2022
211483d
Allow nested SELECT nodes
a74nh Nov 16, 2022
4a4a593
Merge branch main
a74nh Nov 16, 2022
355a3ff
Merge branch main
a74nh Nov 28, 2022
0908788
Fix condition directions
a74nh Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/coreclr/jit/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ set( JIT_SOURCES
hashbv.cpp
hwintrinsic.cpp
hostallocator.cpp
ifconversion.cpp
indirectcalltransformer.cpp
importercalls.cpp
importer.cpp
Expand Down
13 changes: 4 additions & 9 deletions src/coreclr/jit/compiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4755,7 +4755,6 @@ void Compiler::compCompile(void** methodCodePtr, uint32_t* methodCodeSize, JitFl
bool doCse = true;
bool doAssertionProp = true;
bool doRangeAnalysis = true;
bool doIfConversion = true;
bool doVNBasedDeadStoreRemoval = true;
int iterations = 1;

Expand All @@ -4769,7 +4768,6 @@ void Compiler::compCompile(void** methodCodePtr, uint32_t* methodCodeSize, JitFl
doCse = doValueNum;
doAssertionProp = doValueNum && (JitConfig.JitDoAssertionProp() != 0);
doRangeAnalysis = doAssertionProp && (JitConfig.JitDoRangeAnalysis() != 0);
doIfConversion = doIfConversion && (JitConfig.JitDoIfConversion() != 0);
doVNBasedDeadStoreRemoval = doValueNum && (JitConfig.JitDoVNBasedDeadStoreRemoval() != 0);

if (opts.optRepeat)
Expand Down Expand Up @@ -4852,13 +4850,6 @@ void Compiler::compCompile(void** methodCodePtr, uint32_t* methodCodeSize, JitFl
DoPhase(this, PHASE_ASSERTION_PROP_MAIN, &Compiler::optAssertionPropMain);
}

if (doIfConversion)
{
// If conversion
//
DoPhase(this, PHASE_IF_CONVERSION, &Compiler::optIfConversion);
}

if (doRangeAnalysis)
{
// Bounds check elimination via range analysis
Expand Down Expand Up @@ -4910,6 +4901,10 @@ void Compiler::compCompile(void** methodCodePtr, uint32_t* methodCodeSize, JitFl
//
DoPhase(this, PHASE_OPTIMIZE_BOOLS, &Compiler::optOptimizeBools);

// If conversion
//
DoPhase(this, PHASE_IF_CONVERSION, &Compiler::optIfConversion);

// Optimize block order
//
DoPhase(this, PHASE_OPTIMIZE_LAYOUT, &Compiler::optOptimizeLayout);
Expand Down
Loading