Skip to content

[release/7.0] [hot_reload] implement param reflection #77734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 15 commits into from
Nov 3, 2022
Merged

[release/7.0] [hot_reload] implement param reflection #77734

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9e3c042
Add new test ReflectionAddNewMethod
lambdageek Oct 27, 2022
a50e6a5
FIXME: get_param_names, get_marshal_info and custom_attrs need work
lambdageek Oct 27, 2022
130b191
WIP - add a method param reverse lookup
lambdageek Oct 27, 2022
ddb5e1f
look up params from added methods
lambdageek Oct 27, 2022
1e94e62
Remove FIXMEs and unused field
lambdageek Oct 27, 2022
01a653a
remove writelines from test
lambdageek Oct 27, 2022
c935dfa
fix test on coreclr
lambdageek Oct 27, 2022
f4a58e1
why does coreclr have 2 attributes here??
lambdageek Oct 28, 2022
50aa8f9
There should be 2 attributes on the 4th param
lambdageek Oct 28, 2022
b3f903f
one more place that looks at params
lambdageek Oct 29, 2022
8b3c7e9
A couple more places where we look at the Params table
lambdageek Oct 29, 2022
81d4e6d
Check default values on params on added method
lambdageek Oct 29, 2022
9fbb7bd
fix lookup if table is empty
lambdageek Oct 29, 2022
2d191c2
add a gratuitious typeof assert
lambdageek Oct 29, 2022
a29fdb2
Add a single mono_metadata_get_method_params function
lambdageek Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove FIXMEs and unused field
  • Loading branch information
@lambdageek
lambdageek authored and github-actions committed Nov 1, 2022
commit 1e94e62b69ef7a69e85ae07caf024912247d6b20
1 change: 0 additions & 1 deletion src/mono/mono/component/hot_reload-internals.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ typedef struct _MonoClassMetadataUpdateEvent {
} MonoClassMetadataUpdateEvent;

typedef struct _MonoMethodMetadataUpdateParamInfo {
uint32_t method_token; /* which method is this about */
uint32_t first_param_token; /* a Param token */
uint32_t param_count;
} MonoMethodMetadataUpdateParamInfo;
Expand Down
5 changes: 0 additions & 5 deletions src/mono/mono/component/hot_reload.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2392,11 +2392,6 @@ apply_enclog_pass2 (Pass2Context *ctx, MonoImage *image_base, BaselineInfo *base
*/
if (is_addition) {
g_assert (add_field_method != 0);
/*
* FIXME: we need a lookaside table (like member_parent) for every place
* that looks at MONO_METHOD_PARAMLIST
*/

uint32_t parent_type_token = hot_reload_method_parent (image_base, add_field_method);
g_assert (parent_type_token != 0); // we added a parameter to a method that was added
if (pass2_context_is_skeleton (ctx, parent_type_token)) {
Expand Down
1 change: 0 additions & 1 deletion src/mono/mono/metadata/custom-attrs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2250,7 +2250,6 @@ mono_custom_attrs_from_param_checked (MonoMethod *method, guint32 param, MonoErr
return NULL;
ca = &image->tables [MONO_TABLE_METHOD];

/* FIXME: metadata-update - lookup added params */
param_list = mono_metadata_decode_row_col (ca, method_index - 1, MONO_METHOD_PARAMLIST);
if (G_UNLIKELY (param_list == 0 && image->has_updates)) {
uint32_t count;
Expand Down