Skip to content

Use TaskDialog for error dialog in Windows GUI apps #78087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elinor-fung merged 4 commits into from
Jan 18, 2023
Merged

Use TaskDialog for error dialog in Windows GUI apps #78087

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c5323e
Use TaskDialog for error dialog in Windows GUI apps
elinor-fung Nov 9, 2022
9496417
Fix x86 build
elinor-fung Nov 9, 2022
7992b24
Move details, allow cancellation, update doc link intro text
elinor-fung Nov 30, 2022
efe4ce4
Framework: -> Required:
elinor-fung Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix x86 build
  • Loading branch information
@elinor-fung
elinor-fung committed Nov 30, 2022
commit 9496417b0d4945f6d770074d781dfb3063c84ae0
2 changes: 1 addition & 1 deletion src/native/corehost/apphost/apphost.windows.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ namespace

// & indicates an accelerator key when in hyperlink text.
// Replace & with && such that the single ampersand is shown.
for (int i = 0; i < pal::strlen(url); ++i)
for (size_t i = 0; i < pal::strlen(url); ++i)
{
str.push_back(url[i]);
if (url[i] == _X('&'))
Expand Down