Skip to content

Add IndexOfAnyValues #78093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MihaZupan merged 9 commits into from
Nov 21, 2022
Merged

Add IndexOfAnyValues #78093

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1e154c3
Add IndexOfAnyValues
MihaZupan Nov 19, 2022
c520667
Remove IAsciiSet special cases
MihaZupan Nov 19, 2022
a688c23
More tests
MihaZupan Nov 19, 2022
6548ed3
Move expensive tests back to OuterLoop
MihaZupan Nov 19, 2022
5b648d1
Tweak scalar paths
MihaZupan Nov 20, 2022
55817fe
Improve IndexOfAnyValues<T> summary
MihaZupan Nov 20, 2022
1e7684f
Add temporary MONO workaround
MihaZupan Nov 20, 2022
1d79940
Simplify IndexOfAny{1, 2, 3}Values
MihaZupan Nov 20, 2022
fef55c8
Remove redundant AND before shift
MihaZupan Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move expensive tests back to OuterLoop
  • Loading branch information
@MihaZupan
MihaZupan committed Nov 19, 2022
commit 6548ed3b96c8e4ae6454a7e0b3e35aef9774d136
2 changes: 1 addition & 1 deletion src/libraries/System.Memory/tests/Span/IndexOfAny.byte.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ public static void MakeSureNoChecksGoOutOfRangeMany_Byte()
}

[Fact]
//[OuterLoop("Takes about a second to execute")]
[OuterLoop("Takes about a second to execute")]
public static void TestIndexOfAny_RandomInputs_Byte()
{
IndexOfAnyCharTestHelper.TestRandomInputs(
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Memory/tests/Span/IndexOfAny.char.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,7 +777,7 @@ public static void MakeSureNoChecksGoOutOfRangeMany_Char()
}

[Fact]
//[OuterLoop("Takes about a second to execute")]
[OuterLoop("Takes about a second to execute")]
public static void TestIndexOfAny_RandomInputs_Char()
{
IndexOfAnyCharTestHelper.TestRandomInputs(
Expand Down
8 changes: 4 additions & 4 deletions src/libraries/System.Memory/tests/Span/IndexOfAnyExcept.T.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public void SearchingNulls(string[] input, string[] targets, int expected)
}

[Fact]
//[OuterLoop("Takes about a second to execute")]
[OuterLoop("Takes about a second to execute")]
public static void TestIndexOfAnyExcept_RandomInputs_Byte()
{
IndexOfAnyCharTestHelper.TestRandomInputs(
Expand All @@ -80,7 +80,7 @@ static int IndexOfAnyExceptReferenceImpl(ReadOnlySpan<byte> searchSpace, ReadOnl
}

[Fact]
//[OuterLoop("Takes about a second to execute")]
[OuterLoop("Takes about a second to execute")]
public static void TestLastIndexOfAnyExcept_RandomInputs_Byte()
{
IndexOfAnyCharTestHelper.TestRandomInputs(
Expand All @@ -103,7 +103,7 @@ static int LastIndexOfAnyExceptReferenceImpl(ReadOnlySpan<byte> searchSpace, Rea
}

[Fact]
//[OuterLoop("Takes about a second to execute")]
[OuterLoop("Takes about a second to execute")]
public static void TestIndexOfAnyExcept_RandomInputs_Char()
{
IndexOfAnyCharTestHelper.TestRandomInputs(
Expand All @@ -126,7 +126,7 @@ static int IndexOfAnyExceptReferenceImpl(ReadOnlySpan<char> searchSpace, ReadOnl
}

[Fact]
//[OuterLoop("Takes about a second to execute")]
[OuterLoop("Takes about a second to execute")]
public static void TestLastIndexOfAnyExcept_RandomInputs_Char()
{
IndexOfAnyCharTestHelper.TestRandomInputs(
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/System.Memory/tests/Span/LastIndexOfAny.T.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -953,7 +953,7 @@ public static void LastIndexOfAnyNullSequence_String(string[] spanInput, string[
}

[Fact]
//[OuterLoop("Takes about a second to execute")]
[OuterLoop("Takes about a second to execute")]
public static void TestLastIndexOfAny_RandomInputs_Byte()
{
IndexOfAnyCharTestHelper.TestRandomInputs(
Expand All @@ -976,7 +976,7 @@ static int LastIndexOfAnyReferenceImpl(ReadOnlySpan<byte> searchSpace, ReadOnlyS
}

[Fact]
//[OuterLoop("Takes about a second to execute")]
[OuterLoop("Takes about a second to execute")]
public static void TestLastIndexOfAny_RandomInputs_Char()
{
IndexOfAnyCharTestHelper.TestRandomInputs(
Expand Down