Skip to content

Don't emit manifest for NativeRuntimeEventSource #78213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davmason merged 1 commit into from
Nov 13, 2022
Merged

Don't emit manifest for NativeRuntimeEventSource #78213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Don't emit manifest for NativeRuntimeEventSource
  • Loading branch information
@davmason
davmason committed Nov 11, 2022
commit 8a7da0e0b38fc346ff88bff3374970b8453e090b
7 changes: 6 additions & 1 deletion src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2807,8 +2807,13 @@ private void EnsureDescriptorsInitialized()
// Today, we only send the manifest to ETW, custom listeners don't get it.
private unsafe void SendManifest(byte[]? rawManifest)
{
if (rawManifest == null)
if (rawManifest == null
// Don't send the manifest for NativeRuntimeEventSource, it is conceptually
// an extension of the native coreclr provider
|| m_name.Equals("Microsoft-Windows-DotNETRuntime"))
{
return;
}

Debug.Assert(!SelfDescribingEvents);

Expand Down