Skip to content

[release/7.0] [wasm][debugger] Don't escape accented letters #78217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 5 commits into from
Nov 15, 2022
Merged

[release/7.0] [wasm][debugger] Don't escape accented letters #78217

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
19e4a3d
Don't need to escape special characters anymore
thaystg Nov 11, 2022
e046f31
backporting 78320
thaystg Nov 14, 2022
fc47235
Fix characters
thaystg Nov 14, 2022
3f91341
Removing unit tests.
thaystg Nov 14, 2022
6ae64ea
remove unused code.
thaystg Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removing unit tests.
  • Loading branch information
@thaystg
thaystg authored Nov 14, 2022
commit 3f91341577bb151cc51c2785955ffa10accc101a
14 changes: 5 additions & 9 deletions src/mono/wasm/debugger/DebuggerTestSuite/MiscTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,24 +961,21 @@ await EvaluateAndCheck(
[Theory]
[InlineData(
"DebuggerTests.CheckSpecialCharactersInPath",
"dotnet://debugger-test-special-char-in-path.dll/test#.cs",
"debugger-test-special-char-in-path-%23%40/test%23.cs")]
"dotnet://debugger-test-special-char-in-path.dll/test#.cs")]
[InlineData(
"DebuggerTests.CheckSNonAsciiCharactersInPath",
"dotnet://debugger-test-special-char-in-path.dll/non-ascii-test-ął.cs",
"debugger-test-special-char-in-path-%23%40/non-ascii-test-ął.cs")]
"dotnet://debugger-test-special-char-in-path.dll/non-ascii-test-ąłÅ.cs")]
public async Task SetBreakpointInProjectWithSpecialCharactersInPath(
string classWithNamespace, string expectedFileLocation, string expectedFileNameEscaped)
string classWithNamespace, string expectedFileLocation)
{
var bp = await SetBreakpointInMethod("debugger-test-special-char-in-path.dll", classWithNamespace, "Evaluate", 1);
var loc = bp.Value["locations"]?.Value<JArray>()[0];
var ret = await EvaluateAndCheck(
await EvaluateAndCheck(
$"window.setTimeout(function() {{ invoke_static_method ('[debugger-test-special-char-in-path] {classWithNamespace}:Evaluate'); }}, 1);",
expectedFileLocation,
bp.Value["locations"][0]["lineNumber"].Value<int>(),
bp.Value["locations"][0]["columnNumber"].Value<int>(),
$"{classWithNamespace}.Evaluate");
Assert.EndsWith(expectedFileNameEscaped, ret["callFrames"][0]["url"].Value<string>(), StringComparison.InvariantCulture);
}

[Theory]
Expand Down Expand Up @@ -1101,13 +1098,12 @@ await EvaluateAndCheck(
public async Task SetBreakpointInProjectWithChineseCharactereInPath()
{
var bp = await SetBreakpointInMethod("debugger-test-chinese-char-in-path-ㄨ.dll", "DebuggerTests.CheckChineseCharacterInPath", "Evaluate", 1);
var ret = await EvaluateAndCheck(
await EvaluateAndCheck(
$"window.setTimeout(function() {{ invoke_static_method ('[debugger-test-chinese-char-in-path-ㄨ] DebuggerTests.CheckChineseCharacterInPath:Evaluate'); }}, 1);",
"dotnet://debugger-test-chinese-char-in-path-ㄨ.dll/test.cs",
bp.Value["locations"][0]["lineNumber"].Value<int>(),
bp.Value["locations"][0]["columnNumber"].Value<int>(),
$"DebuggerTests.CheckChineseCharacterInPath.Evaluate");
Assert.EndsWith("debugger-test-chinese-char-in-path-ㄨ/test.cs", ret["callFrames"][0]["url"].Value<string>(), StringComparison.InvariantCulture);
}

[Fact]
Expand Down