Skip to content

ArgOutOfRangeException throw helpers #78222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 17 commits into from
Dec 1, 2022
Merged

ArgOutOfRangeException throw helpers #78222

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
661eef8
add implementation
hrrrrustic Nov 11, 2022
1900b3a
add docs
hrrrrustic Nov 11, 2022
39e6e81
Add some tests
hrrrrustic Nov 11, 2022
600b947
Some replacements in CoreLib root namespace
hrrrrustic Nov 11, 2022
91e279e
Apply suggestions from code review
hrrrrustic Nov 11, 2022
541389f
Inline negativeorzero
hrrrrustic Nov 13, 2022
ad4aff8
fix messages
hrrrrustic Nov 13, 2022
722f5b7
fix throwing
hrrrrustic Nov 13, 2022
3c5fe6d
fix paramnames
hrrrrustic Nov 13, 2022
65d5d23
fix nullability
hrrrrustic Nov 13, 2022
9f81c22
one more paramname fix
hrrrrustic Nov 14, 2022
0709d8c
make private throwers generic
hrrrrustic Nov 23, 2022
0067cbd
Apply suggestions from code review
hrrrrustic Nov 24, 2022
b760a77
apply review comments
hrrrrustic Nov 24, 2022
6893695
few more cleanups
hrrrrustic Nov 24, 2022
b65e7d5
Merge branch 'main' into issue-69590
stephentoub Dec 1, 2022
dd0ad2f
Address my own PR feedback and use helpers in more places
stephentoub Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
one more paramname fix
  • Loading branch information
@hrrrrustic
hrrrrustic committed Nov 14, 2022
commit 9f81c222a83ba77a8705cd6c2f80cbf7a62a8c45
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/System/DateTime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1700,7 +1700,7 @@ public long ToFileTimeUtc()
}

ticks -= FileTimeOffset;
ArgumentOutOfRangeException.ThrowIfNegative(ticks);
ArgumentOutOfRangeException.ThrowIfNegative(ticks, null);
Copy link
Member

@stephentoub stephentoub Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're losing context in the message here. We need to decide how much we care.

Copy link
Contributor Author

@hrrrrustic hrrrrustic Nov 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You marked this as resolved, so replacement is fine?
I just thinking that I can revert that one to make this initial PR like more straightforward without any edge cases. We can return here in another separate PR with replacements

Copy link
Member

@stephentoub stephentoub Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just thinking that I can revert that one to make this initial PR like more straightforward without any edge cases. We can return here in another separate PR with replacements

Ok, thanks.


return ticks;
}
Expand Down