[wasm] Use Helix's retry mechanism to re-run debugger tests on CI if .. #78357
Conversation
.. they failed while waiting for the browser to launch. Related: https://github.com/dotnet/arcade/tree/main/src/Microsoft.DotNet.Helix/Sdk#test-retry Fixes dotnet#76528
radical
added
arch-wasm
ghost
assigned
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details.. they failed while waiting for the browser to launch. Related: https://github.com/dotnet/arcade/tree/main/src/Microsoft.DotNet.Helix/Sdk#test-retry Fixes #76528
|
| "retryOnRules": [ | ||
| { "testAssembly": { "wildcard": "System.Net.*" } } | ||
| { "testAssembly": { "wildcard": "System.Net.*" } }, | ||
| { "failureMessage": { "wildcard": "Timed out after * waiting for the browser to be ready" } } |
There was a problem hiding this comment.
do you know if this does a substring match? e.g. the message will normally have messagePrefix and psi.FileName before/after, do we need to add * at the beginning/end too?
There was a problem hiding this comment.
https://github.com/dotnet/arcade/tree/main/src/Microsoft.DotNet.Helix/Sdk#wildcard-value-with--wildcard suggests, IIUC, that it should match a substring.
There was a problem hiding this comment.
Looks like that didn't work - https://dev.azure.com/dnceng-public/public/_build/results?buildId=86544&view=ms.vss-test-web.build-test-results-tab&runId=1812800&resultId=100139&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab . I'll open a new PR, and explicitly reproduce the error.
There was a problem hiding this comment.
Oh, and reading the docs again:
Raw string (e.g. "rule string")
True if the property value exactly matches the string
{"wildcard": "value with * wildcard"}
The same as a raw string, but "*" can match any number of characters, and "?" can match one charactersame as raw string, and raw string says that it will match the property value exactly.
And the property value I'm using here:
failureMessage
The failure message logged by the test
So, you were likely correct. I will try regex instead.
|
|
2 participants
.. they failed while waiting for the browser to launch.
Related: https://github.com/dotnet/arcade/tree/main/src/Microsoft.DotNet.Helix/Sdk#test-retry
Fixes #76528