Skip to content

[Release/6.0][PERF] Fix perf repo branch setup target, tool build, and mono-dotnet create #78411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 9 commits into from
Nov 30, 2022
Merged

[Release/6.0][PERF] Fix perf repo branch setup target, tool build, and mono-dotnet create #78411

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
039594b
Disabled Transitive Framework download when building tools and set th…
LoopedBard3 Nov 10, 2022
29d3bc7
Changed default branch name from main to release/6.0.
LoopedBard3 Nov 10, 2022
8463380
Update target framework for tool builds to net6.0, and update corerun…
LoopedBard3 Nov 14, 2022
6199fb3
Versions.props are not passed through to the azure yaml, so these val…
LoopedBard3 Nov 14, 2022
4c0b864
Remove the dot in Microbenchmarks as perf setup copies the files over…
LoopedBard3 Nov 15, 2022
e85b13c
Switch to using the product version from the Version.props file by se…
LoopedBard3 Nov 29, 2022
0fd4cc5
Setup testing for proj based productversion.
LoopedBard3 Nov 29, 2022
64f713a
Revert "Setup testing for proj based productversion."
LoopedBard3 Nov 29, 2022
75a86f6
Add product version to the MicroBenchmarks and final cleanup.
LoopedBard3 Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add product version to the MicroBenchmarks and final cleanup.
  • Loading branch information
@LoopedBard3
LoopedBard3 committed Nov 29, 2022
commit 75a86f62b69314cda91da4886ea77873fbeef382
1 change: 1 addition & 0 deletions eng/pipelines/coreclr/templates/perf-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ jobs:
- script: |
$(Build.SourcesDirectory)/eng/common/msbuild.sh $(Build.SourcesDirectory)/eng/testing/performance/add_properties_to_pipeline.proj /t:SetVariables
displayName: Add Properties To Pipeline Env

# Optionally download live-built libraries
- ${{ if ne(parameters.liveLibrariesBuildConfig, '') }}:
- template: /eng/pipelines/common/download-artifact-step.yml
Expand Down
4 changes: 2 additions & 2 deletions eng/testing/performance/microbenchmarks.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@
</PropertyGroup>

<PropertyGroup Condition="'$(MonoDotnet)' == 'true' and '$(AGENT_OS)' == 'Windows_NT'">
<CoreRunArgument>--corerun %HELIX_CORRELATION_PAYLOAD%\dotnet-mono\shared\Microsoft.NETCore.App\6.0.12\corerun.exe</CoreRunArgument>
<CoreRunArgument>--corerun %HELIX_CORRELATION_PAYLOAD%\dotnet-mono\shared\Microsoft.NETCore.App\$(ProductVersion)\corerun.exe</CoreRunArgument>
</PropertyGroup>
<PropertyGroup Condition="'$(MonoDotnet)' == 'true' and '$(AGENT_OS)' != 'Windows_NT'">
<CoreRunArgument>--corerun $(BaseDirectory)/dotnet-mono/shared/Microsoft.NETCore.App/6.0.12/corerun</CoreRunArgument>
<CoreRunArgument>--corerun $(BaseDirectory)/dotnet-mono/shared/Microsoft.NETCore.App/$(ProductVersion)/corerun</CoreRunArgument>
</PropertyGroup>

<PropertyGroup Condition="'$(UseCoreRun)' == 'true'">
Expand Down