Skip to content

[WIP] Fix to move to using GC pal within coreclr on Linux #78521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mangod9 wants to merge 5 commits into from
Closed

[WIP] Fix to move to using GC pal within coreclr on Linux #78521

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef751dc
Modify __int64 definition in PAL to match the OS definition (#77056)
janvorli Oct 18, 2022
8183541
Fix the __int64 to be long long on macOS only (#77268)
janvorli Oct 20, 2022
16495db
statically linking GC PAL on linux (#76985)
mangod9 Oct 25, 2022
540ea21
check the right return value for mmap (#77952)
mangod9 Nov 7, 2022
520c8c3
fixing alignment check which affects MacOS
mangod9 Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixing alignment check which affects MacOS 
This was manually picked from: #75264 which was already present in main, before the PAL change.
  • Loading branch information
@mangod9
mangod9 committed Nov 22, 2022
commit 520c8c3dcfd2ef4d6250d1aed19e033c37f68a71
2 changes: 1 addition & 1 deletion src/coreclr/gc/unix/gcenv.unix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ void GCToOSInterface::YieldThread(uint32_t switchCount)
static void* VirtualReserveInner(size_t size, size_t alignment, uint32_t flags, uint32_t hugePagesFlag = 0)
{
assert(!(flags & VirtualReserveFlags::WriteWatch) && "WriteWatch not supported on Unix");
if (alignment == 0)
if (alignment < OS_PAGE_SIZE)
{
alignment = OS_PAGE_SIZE;
}
Expand Down