Skip to content

Use IndexOfAnyValues in Uri #78666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MihaZupan merged 6 commits into from
Nov 23, 2022
Merged

Use IndexOfAnyValues in Uri #78666

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b7224c1
Use IndexOfAnyValues in Uri
MihaZupan Nov 21, 2022
1636c4a
Fix CheckSchemeName typo
MihaZupan Nov 22, 2022
6f4b871
Fix debug assert condition
MihaZupan Nov 22, 2022
076c002
Fix DomainNameHelper
MihaZupan Nov 22, 2022
87c7f61
Fix IRI domain name parsing for [80, 9F] chars
MihaZupan Nov 22, 2022
471138b
PR feedback
MihaZupan Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix debug assert condition
  • Loading branch information
@MihaZupan
MihaZupan committed Nov 22, 2022
commit 6f4b8719fa5f33c3fd564aa3c2c831242776e057
2 changes: 1 addition & 1 deletion src/libraries/System.Private.Uri/src/System/DomainNameHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ internal static string ParseCanonicalName(string str, int start, int end, ref bo
int index = str.AsSpan(start, end - start).LastIndexOfAny(s_asciiLetterUpperOrColonChars);
if (index >= 0)
{
Debug.Assert(!str.AsSpan(start, index - start).Contains(':'),
Debug.Assert(!str.AsSpan(start, index).Contains(':'),
"A colon should appear at most once, and must never be followed by letters.");
Copy link
Member

@stephentoub stephentoub Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ParseCanonicalName is handed already sanitized data?

Copy link
Member Author

@MihaZupan MihaZupan Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes


if (str[start + index] == ':')
Expand Down