Skip to content

Fix the tiering delay to account for changing IL/native code versions during the delay #78668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kouvel merged 1 commit into from
Nov 23, 2022
Merged

Fix the tiering delay to account for changing IL/native code versions during the delay #78668

kouvel merged 1 commit into from
Nov 23, 2022
+9 −2

Conversation

@kouvel
Copy link
Contributor

@kouvel kouvel commented Nov 21, 2022

  • Added a check to see if the currently active native code version has a code entry point

Fixes #77973

Fix the tiering delay to account for changing IL/native code versions…
9420cb3 
… during the delay

- Added a check to see if the currently active native code version has a code entry point

Fixes #77973
@kouvel kouvel added this to the 8.0.0 milestone Nov 21, 2022
@kouvel kouvel requested review from davmason and noahfalk November 21, 2022 23:56
@kouvel kouvel self-assigned this Nov 21, 2022
This was referenced Nov 22, 2022
Merged
Merged
noahfalk
noahfalk approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kouvel kouvel merged commit 722745e into dotnet:main Nov 23, 2022
@kouvel kouvel deleted the TierFix branch November 23, 2022 05:21
@kouvel
Copy link
Contributor Author

kouvel commented Nov 23, 2022

Thanks @noahfalk, could you please sign off on the 7.0 and 6.0 PRs also? The changes are identical, 7.0: #78669, 6.0: #78670

carlossanlop pushed a commit that referenced this pull request Nov 29, 2022
@kouvel
[7.0] Fix the tiering delay to account for changing IL/native code ve…
e13ac7a 
…rsions during the delay (#78669)

- Port of #78668
- Added a check to see if the currently active native code version has a code entry point

Fixes #77973
carlossanlop pushed a commit that referenced this pull request Nov 29, 2022
@kouvel
[6.0] Fix the tiering delay to account for changing IL/native code ve…
7fa7f65 
…rsions during the delay (#78670)

- Port of #78668
- Added a check to see if the currently active native code version has a code entry point

Fixes #77973
@ghost ghost locked as resolved and limited conversation to collaborators Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@noahfalk noahfalk noahfalk approved these changes

@davmason davmason Awaiting requested review from davmason

Assignees

@kouvel kouvel

Labels

area-TieredCompilation-coreclr

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

AccessViolation when calling rejitted method

2 participants

@kouvel @noahfalk