[release/7.0] Fix netfx build for S.S.C.Xml nuget package #78734
Conversation
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBackport of #78665 to release/7.0 /cc @bartonjs Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
Changes look good. This is tell-mode, no need to send email to Tactics.
@ViktorHofer do we need any special additional changes for the servicing on these two packages?
If that means I should have picked a label other than |
carlossanlop
added
Servicing-approved
|
It's a regression in product code from a previous release which doesn't sound like a tell-mode change. Anyways, I see that the servicing-approved label got added so I assume Tactics already approved it. |
|
This isn't making December, it will make Jan. |
|
Yes, that's alright. I just merged it in advance. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #78665 to release/7.0
/cc @bartonjs
Customer Impact
Customers upgrading NuGet package references from 6.0.x to 7.0.0 find that the System.Security.Cryptography.Xml and System.Threading.AccessControl packages no longer work on .NET Framework, generally manifesting as a TypeLoadException when used by an intermediate library built targeting .NET Standard 2.0
Testing
Built the release/7.0 branch with this change applied, extracted the
lib/net462DLL for each package, and verified all of the typeforwards are present in the updated versions.Risk
Low.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.