Skip to content

Wasm jiterpreter cleanup and bug fixes pt. 3 #78782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kg merged 12 commits into from
Dec 2, 2022
Merged

Wasm jiterpreter cleanup and bug fixes pt. 3 #78782

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
08d0aa0
Unroll memmove like memset
kg Nov 23, 2022
f1655f2
Add runtime option that causes interpreter and jiterpreter tiering me…
kg Nov 23, 2022
17ae775
Implement floating point relops in WASM using a C function to preserv…
kg Nov 23, 2022
c12d76c
Revert config changes
kg Nov 23, 2022
41db270
Whitespace cleanup
kg Nov 23, 2022
8113ec4
Repair merge damage
kg Nov 23, 2022
d69318d
Hoist unordered check
kg Nov 23, 2022
d4dc093
Make interp_exec_method static again, because that appears to improve…
kg Nov 24, 2022
138070d
Remove tier_instantly (not necessary) and address PR feedback
kg Nov 29, 2022
05d90cb
Remove header change
kg Nov 29, 2022
d6ff4e5
remove ts side tier instantly
kg Nov 29, 2022
d29e7ce
Enable jiterpreter if tiering is disabled, update stats
kg Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Whitespace cleanup
  • Loading branch information
@kg
kg committed Nov 23, 2022
commit 41db2704b9633a9cb6bd4e89b1e41986b3b75427
21 changes: 0 additions & 21 deletions src/mono/wasm/runtime/jiterpreter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1915,27 +1915,6 @@ const binopTable : { [opcode: number]: OpRec3 | OpRec4 | undefined } = {
[MintOpcode.MINT_CLE_UN_I8]: [WasmOpcode.i64_le_u, WasmOpcode.i64_load, WasmOpcode.i32_store],
[MintOpcode.MINT_CGE_UN_I8]: [WasmOpcode.i64_ge_u, WasmOpcode.i64_load, WasmOpcode.i32_store],

/*
[MintOpcode.MINT_CEQ_R4]: [WasmOpcode.f32_eq, WasmOpcode.f32_load, WasmOpcode.i32_store],
[MintOpcode.MINT_CNE_R4]: [WasmOpcode.f32_ne, WasmOpcode.f32_load, WasmOpcode.i32_store],
[MintOpcode.MINT_CLT_R4]: [WasmOpcode.f32_lt, WasmOpcode.f32_load, WasmOpcode.i32_store],
// FIXME: What are these, semantically?
[MintOpcode.MINT_CLT_UN_R4]: [WasmOpcode.f32_lt, WasmOpcode.f32_load, WasmOpcode.i32_store],
[MintOpcode.MINT_CGT_R4]: [WasmOpcode.f32_gt, WasmOpcode.f32_load, WasmOpcode.i32_store],
// FIXME
[MintOpcode.MINT_CGT_UN_R4]: [WasmOpcode.f32_gt, WasmOpcode.f32_load, WasmOpcode.i32_store],
[MintOpcode.MINT_CLE_R4]: [WasmOpcode.f32_le, WasmOpcode.f32_load, WasmOpcode.i32_store],
[MintOpcode.MINT_CGE_R4]: [WasmOpcode.f32_ge, WasmOpcode.f32_load, WasmOpcode.i32_store],

[MintOpcode.MINT_CEQ_R8]: [WasmOpcode.f64_eq, WasmOpcode.f64_load, WasmOpcode.i32_store],
[MintOpcode.MINT_CNE_R8]: [WasmOpcode.f64_ne, WasmOpcode.f64_load, WasmOpcode.i32_store],
[MintOpcode.MINT_CLT_R8]: [WasmOpcode.f64_lt, WasmOpcode.f64_load, WasmOpcode.i32_store],
[MintOpcode.MINT_CGT_R8]: [WasmOpcode.f64_gt, WasmOpcode.f64_load, WasmOpcode.i32_store],
[MintOpcode.MINT_CLE_R8]: [WasmOpcode.f64_le, WasmOpcode.f64_load, WasmOpcode.i32_store],
[MintOpcode.MINT_CGE_R8]: [WasmOpcode.f64_ge, WasmOpcode.f64_load, WasmOpcode.i32_store],
*/

// FIXME: unordered float comparisons
};

const relopbranchTable : { [opcode: number]: [comparisonOpcode: MintOpcode, immediateOpcode: WasmOpcode | false, isSafepoint: boolean] | MintOpcode | undefined } = {
Expand Down