Skip to content

JIT: Fold const RVA access (via const index) #78783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EgorBo merged 24 commits into from
Nov 29, 2022
Merged

JIT: Fold const RVA access (via const index) #78783

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
f335448
Fold const RVA access
EgorBo Nov 23, 2022
0282bfe
fix build
EgorBo Nov 23, 2022
9780a9a
Address feedback
EgorBo Nov 23, 2022
ae56d28
Clean up
EgorBo Nov 23, 2022
e35ac7c
fix compilation
EgorBo Nov 24, 2022
b8e2dd5
NativeAOT support (jit side)
EgorBo Nov 24, 2022
aaf129e
Update src/coreclr/vm/jitinterface.cpp
EgorBo Nov 24, 2022
f7b0d4e
Implement NativeAOT side
EgorBo Nov 24, 2022
1a6400a
Merge branch 'fold-const-rva' of github.com:EgorBo/runtime-1 into fol…
EgorBo Nov 24, 2022
29f4e9d
Update assertionprop.cpp
EgorBo Nov 24, 2022
8d471c1
Add tests, clean up
EgorBo Nov 24, 2022
7f402fc
Update ConstIndexRVA.cs
EgorBo Nov 24, 2022
14743b6
fix test
EgorBo Nov 24, 2022
784d02b
Merge branch 'fold-const-rva' of github.com:EgorBo/runtime-1 into fol…
EgorBo Nov 24, 2022
0dbc4c2
Merge branch 'main' of github.com:dotnet/runtime into fold-const-rva
EgorBo Nov 24, 2022
677c55d
Merge branch 'main' of github.com:dotnet/runtime into fold-const-rva
EgorBo Nov 25, 2022
142ad61
Address feedback
EgorBo Nov 26, 2022
66e481c
fix assert
EgorBo Nov 26, 2022
c4aa231
Update src/coreclr/tools/aot/ILCompiler.ReadyToRun/JitInterface/CorIn…
EgorBo Nov 26, 2022
8164730
Fix AOT
EgorBo Nov 26, 2022
7c55cea
Merge branch 'main' of github.com:dotnet/runtime into fold-const-rva
EgorBo Nov 28, 2022
d718816
Address feedback
EgorBo Nov 28, 2022
f8051a8
make tryReadRvaFieldData static
EgorBo Nov 28, 2022
f45a76e
address feedback
EgorBo Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix assert
  • Loading branch information
@EgorBo
EgorBo committed Nov 26, 2022
commit 66e481c46b2fd93b4c0fb91c9e60fd173a687cfd
3 changes: 2 additions & 1 deletion src/coreclr/jit/valuenum.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8578,7 +8578,8 @@ bool Compiler::fgValueNumberConstLoad(GenTreeIndir* tree)
//
ssize_t address = 0;
FieldSeq* fieldSeq = nullptr;
if (fgGetFieldSeqAndAddress(tree->gtGetOp1(), &address, &fieldSeq))
if (fgGetFieldSeqAndAddress(tree->gtGetOp1(), &address, &fieldSeq) &&
(fieldSeq->GetKind() == FieldSeq::FieldKind::SimpleStaticKnownAddress))
{
CORINFO_FIELD_HANDLE fieldHandle = fieldSeq->GetFieldHandle();
assert(fieldSeq->GetKind() == FieldSeq::FieldKind::SimpleStaticKnownAddress);
Expand Down