Skip to content

Enable basic Kept validation in NativeAOT running linker tests #78828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitek-karas merged 11 commits into from
Nov 30, 2022
Merged

Enable basic Kept validation in NativeAOT running linker tests #78828

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
86aa062
Initial changes to support KeptAttribute in AOT validation
vitek-karas Nov 21, 2022
308da87
Better infra
vitek-karas Nov 21, 2022
ca7f956
Progress
vitek-karas Nov 23, 2022
1076b77
Working
vitek-karas Nov 23, 2022
c6ccc5e
Cleanup
vitek-karas Nov 24, 2022
b5b8aa4
More cleanup
vitek-karas Nov 24, 2022
466cf74
Formatting
vitek-karas Nov 24, 2022
748cdd1
PR Feedback
vitek-karas Nov 28, 2022
566656f
Merge main and fixes for conflicts
vitek-karas Nov 29, 2022
d482725
PR Feedback
vitek-karas Nov 30, 2022
26bdb3b
Update src/coreclr/tools/aot/Mono.Linker.Tests/TestCasesRunner/Result…
vitek-karas Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Working
  • Loading branch information
@vitek-karas
vitek-karas committed Nov 24, 2022
commit 1076b77ec66a3af466dcbeba69d6686aa6ba6837
1 change: 0 additions & 1 deletion src/coreclr/tools/aot/ILCompiler/ILCompilerRootCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
using System.CommandLine.Help;
using System.CommandLine.Parsing;
using System.IO;
using System.Runtime.InteropServices;

using Internal.TypeSystem;

Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/tools/aot/Mono.Linker.Tests.Cases/DataFlow/IReflectDataflow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ public static void Test ()
var i = new MyReflectOverType (typeof (TestType));
i.GetFields (BindingFlags.Instance | BindingFlags.Public);

#if NATIVE_AOT
#if NATIVEAOT
// In Native AOT the test infra doesn't setup the compiler in a way where it will force preserve
// all external types. Like here, it will actually track usage of methods on IReflect
// and remove any which are not used. We don't want that for this test.
Expand Down
135 changes: 0 additions & 135 deletions src/coreclr/tools/aot/Mono.Linker.Tests.Cases/DataFlow/UnresolvedMembers.cs
View file
Open in desktop

This file was deleted.

Loading