Skip to content

Exclude things which broken on Loongarch #78850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kant2002 wants to merge 12 commits into from
Closed

Exclude things which broken on Loongarch #78850

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a22df01
Ignore JSImportGenerator
kant2002 Nov 25, 2022
2763ce1
Disable building Crossgen2
kant2002 Nov 24, 2022
1fd832f
Unlock building test layout
kant2002 Nov 30, 2022
186ef52
Add custom restore source only for LA64 arch
kant2002 Dec 2, 2022
c0aec51
Hmm, sometimes I do wierd mistakes
kant2002 Dec 2, 2022
bcb228e
Test project want to use Microsoft.NETCore.App.Runtime.linux-loongarc…
kant2002 Dec 5, 2022
7739236
Apply PR feedback
kant2002 Feb 20, 2023
830c779
Merge branch 'main' into kant/exclude-loongarch-not-implemented
kant2002 Feb 20, 2023
3ac0716
Move exclusion to tests.proj
kant2002 Feb 20, 2023
874b12f
Removed warning. Let's see how it worked out from main after this merges
kant2002 Feb 26, 2023
94d0e44
Merge branch 'main' into kant/exclude-loongarch-not-implemented
kant2002 Apr 18, 2023
76cad70
Use same method for disabling crossgen as Risk-V
kant2002 Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable building Crossgen2 
Hope that's all what's needed for #78749
  • Loading branch information
@kant2002
kant2002 committed Nov 25, 2022
commit 2763ce1d25f9fd40f49b23888c2611eaaf528ea9
4 changes: 2 additions & 2 deletions eng/Subsets.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@
$(CoreClrProjectRoot)tools\dotnet-pgo\dotnet-pgo.csproj;
$(CoreClrProjectRoot)tools\aot\ILCompiler\repro\repro.csproj;
$(CoreClrProjectRoot)tools\r2rtest\R2RTest.csproj" Category="clr" Condition="'$(DotNetBuildFromSource)' != 'true'"/>
<ProjectToBuild Include="$(CoreClrProjectRoot)tools\aot\crossgen2\crossgen2.csproj" Category="clr" />
<ProjectToBuild Condition="'$(TargetArchitecture)' != 'loongarch64'" Include="$(CoreClrProjectRoot)tools\aot\crossgen2\crossgen2.csproj" Category="clr" />
<ProjectToBuild Include="$(CoreClrProjectRoot)tools\aot\ILCompiler.Build.Tasks\ILCompiler.Build.Tasks.csproj" Category="clr" Condition="'$(NativeAotSupported)' == 'true'" />
<ProjectToBuild Include="$(CoreClrProjectRoot)tools\aot\ILCompiler\ILCompiler.csproj" Category="clr" Condition="'$(NativeAotSupported)' == 'true'" />
<ProjectToBuild Include="$(CoreClrProjectRoot)nativeaot\BuildIntegration\BuildIntegration.proj" Category="clr" Condition="'$(NativeAotSupported)' == 'true'" />
Expand Down Expand Up @@ -355,7 +355,7 @@
Test="true" Category="tools"/>
</ItemGroup>

<ItemGroup Condition="$(_subset.Contains('+clr.nativecorelib+'))">
<ItemGroup Condition="$(_subset.Contains('+clr.nativecorelib+')) and '$(TargetArchitecture)' != 'loongarch64'">
<!-- Build crossgen2 that will be used to compile System.Private.CoreLib library for CoreCLR -->
<ProjectToBuild Condition="'$(TargetArchitecture)' != 'x64' and '$(BuildArchitecture)' == 'x64'" Include="$(CoreClrProjectRoot)tools\aot\crossgen2\crossgen2_crossarch.csproj" Category="clr" />
<ProjectToBuild Condition="!('$(TargetArchitecture)' != 'x64' and '$(BuildArchitecture)' == 'x64')" Include="$(CoreClrProjectRoot)tools\aot\crossgen2\crossgen2.csproj" Category="clr" />
Expand Down