Skip to content

Fix configuration binding with types implementing IDictionary<,> #78946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarekgh merged 5 commits into from
Nov 30, 2022
Merged

Fix configuration binding with types implementing IDictionary<,> #78946

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
96ef743
Fix configuration binding with types implementing IDictionary
tarekgh Nov 29, 2022
08ba1fa
Apply suggestions from code review
tarekgh Nov 29, 2022
a1512e6
Address the feedback
tarekgh Nov 29, 2022
27feb0f
Merge branch 'FixConfigurationBindingWithTypesImplmentingDictionary' …
tarekgh Nov 29, 2022
e5db199
more feedback
tarekgh Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...es/Microsoft.Extensions.Configuration.Binder/tests/ConfigurationCollectionBindingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1673,8 +1673,8 @@ public class ImplementerOfIDictionaryClass<TKey, TValue> : IDictionary<TKey, TVa

System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator() => _dict.GetEnumerator();

// The following are members which has same names as the IDictionary<,> members.
// Adding these to the test to ensure not getting System.Reflection.AmbiguousMatchException when we bind the dictionary.
// The following are members which have the same names as the IDictionary<,> members.
// The following members test that there's no System.Reflection.AmbiguousMatchException when binding to the dictionary.
private string? v;
public string? this[string key] { get => v; set => v = value; }
public bool TryGetValue() { return true; }
Expand Down