Skip to content

Remove FILEDosToUnixPathA conversion #78995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janvorli merged 5 commits into from
Dec 2, 2022
Merged

Remove FILEDosToUnixPathA conversion #78995

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
06e9e8f
Remove FILEDosToUnixPathA conversion
janvorli Nov 29, 2022
ba1e577
Remove checks for `\` on Unix and some conversions
janvorli Nov 30, 2022
4553e3a
Update runtime to use platform specific directory separator
janvorli Nov 30, 2022
48e4852
Revert changes at few places and remove some code for Unix
janvorli Dec 1, 2022
21f9424
Fix Bundle_Extraction_To_Relative_Path_Succeeds host test
janvorli Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix Bundle_Extraction_To_Relative_Path_Succeeds host test 
Exclude the `foo\\bar` case for non-Windows.
  • Loading branch information
@janvorli
janvorli committed Dec 1, 2022
commit 21f94246c55829c0766ef67793c5f8cedfdc8dce
5 changes: 5 additions & 0 deletions ...r/tests/Microsoft.NET.HostModel.Tests/AppHost.Bundle.Tests/BundleExtractToSpecificPath.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,11 @@ private void Bundle_Extraction_To_Relative_Path_Succeeds(string relativePath, Bu
if (relativePath == "foo/bar" && OperatingSystem.IsWindows())
return;

// Similarly on non-Windows OSes, we don't convert backslash directory separators
// to forward ones.
if (relativePath == "foo\\bar" && !OperatingSystem.IsWindows())
return;

var fixture = sharedTestState.TestFixture.Copy();
var bundler = BundleSelfContainedApp(fixture, out var singleFile, bundleOptions);

Expand Down