Skip to content

Handle zero value modulus for OpenSSL 1.1 #79013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vcsjones merged 14 commits into from
Dec 7, 2022
Merged

Handle zero value modulus for OpenSSL 1.1 #79013

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7bc30ea
Handle zero value modulus for OpenSSL 1.1
vcsjones Nov 14, 2022
846510d
Fix build for OpenSSL 1.0
vcsjones Nov 14, 2022
535601b
Undef existing name prior to re-defining
vcsjones Nov 15, 2022
9ecfda0
Skip test on Windows 7
vcsjones Nov 15, 2022
ac463aa
Make random change to CLR to get Linux x86 to build
vcsjones Nov 30, 2022
562b107
Try getting this job to run
vcsjones Dec 6, 2022
6ebb71d
Revert "Try getting this job to run"
vcsjones Dec 6, 2022
9ab47a7
Merge remote-tracking branch 'ms/main' into openssl11-rsa-zero-mod
vcsjones Dec 6, 2022
5f747e6
Try getting this job to run
vcsjones Dec 6, 2022
15609b4
Use staging x86 docker image
akoeplinger Dec 7, 2022
4b254ff
Revert "Use staging x86 docker image"
vcsjones Dec 7, 2022
400ae4c
Revert "Try getting this job to run"
vcsjones Dec 7, 2022
4678cab
Revert "Make random change to CLR to get Linux x86 to build"
vcsjones Dec 7, 2022
dea7c64
Use error that is present in OpenSSL 1.0.2
vcsjones Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use error that is present in OpenSSL 1.0.2
  • Loading branch information
@vcsjones
vcsjones committed Dec 7, 2022
commit dea7c6401a2c79573c19dd6470a3274a9abac0b8
2 changes: 1 addition & 1 deletion src/native/libs/System.Security.Cryptography.Native/pal_evp_pkey.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ static bool CheckKey(EVP_PKEY* key, int32_t algId, int32_t (*check_func)(EVP_PKE

if (modulus != NULL && BN_is_zero(modulus))
{
ERR_put_error(ERR_LIB_EVP, 0, EVP_R_INVALID_KEY, __FILE__, __LINE__);
ERR_put_error(ERR_LIB_EVP, 0, EVP_R_DECODE_ERROR, __FILE__, __LINE__);
return false;
}
}
Expand Down