Skip to content

[hot_reload] Enable some CustomAttributes tests on Mono; new issue for async #79044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lambdageek merged 1 commit into from
Dec 1, 2022
Merged

[hot_reload] Enable some CustomAttributes tests on Mono; new issue for async #79044

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[hot_reload] Enable some CustomAttributes tests on Mono; new issue fo… 
…r async

The async test was marked with the CustomAttributes tracking issue, but it's
actually unrelated.

Fixes #52993
  • Loading branch information
@lambdageek
lambdageek committed Nov 30, 2022
commit 33e031044fc71d63a4c391cdc41e314f0897dd7f
4 changes: 1 addition & 3 deletions src/libraries/System.Runtime.Loader/tests/ApplyUpdateTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ void FirstCallAfterUpdate()
}

[ConditionalFact(typeof(ApplyUpdateUtil), nameof (ApplyUpdateUtil.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/52993", TestRuntimes.Mono)]
void ClassWithCustomAttributes()
{
ApplyUpdateUtil.TestCase(static () =>
Expand Down Expand Up @@ -191,7 +190,6 @@ public void CustomAttributeUpdates()
});
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/52993", TestRuntimes.Mono)]
[ConditionalFact(typeof(ApplyUpdateUtil), nameof (ApplyUpdateUtil.IsSupported))]
public void CustomAttributeDelete()
{
Expand Down Expand Up @@ -231,7 +229,7 @@ public void CustomAttributeDelete()
});
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/52993", TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/79043", TestRuntimes.Mono)]
[ConditionalFact(typeof(ApplyUpdateUtil), nameof (ApplyUpdateUtil.IsSupported))]
public void AsyncMethodChanges()
{
Expand Down