wip

src/native/libs/System.Native/pal_console_wasi.c

@@ -17,6 +17,12 @@
 #include <poll.h>
 #include <signal.h>
 
+#ifdef DEBUG
+#define DEBUGNOTRETURN __attribute__((noreturn))
+#else
+#define DEBUGNOTRETURN
+#endif
+
 int32_t SystemNative_GetWindowSize(WinSize* windowSize)
 {
     assert(windowSize != NULL);
@@ -28,7 +34,6 @@ int32_t SystemNative_GetWindowSize(WinSize* windowSize)
 int32_t SystemNative_SetWindowSize(WinSize* windowSize)
 {
     assert(windowSize != NULL);
-    (void)windowSize;
     errno = ENOTSUP;
     return -1;
 }
@@ -38,36 +43,32 @@ int32_t SystemNative_IsATty(intptr_t fd)
     return isatty(ToFileDescriptor(fd));
 }
 
-__attribute__((noreturn))
+DEBUGNOTRETURN
 void SystemNative_SetKeypadXmit(const char* terminfoString)
 {
-    (void)terminfoString; //unused
     assert(terminfoString != NULL);
     assert_msg(false, "Not supported on WASI", 0);
 }
 
-__attribute__((noreturn))
+DEBUGNOTRETURN
 void SystemNative_InitializeConsoleBeforeRead(uint8_t minChars, uint8_t decisecondsTimeout)
 {
-    (void)minChars; //unused
-    (void)decisecondsTimeout; //unused
     assert_msg(false, "Not supported on WASI", 0);
 }
 
-__attribute__((noreturn))
+DEBUGNOTRETURN
 void SystemNative_UninitializeConsoleAfterRead(void)
 {
     assert_msg(false, "Not supported on WASI", 0);
 }
 
-__attribute__((noreturn))
+DEBUGNOTRETURN
 void SystemNative_ConfigureTerminalForChildProcess(int32_t childUsesTerminal)
 {
-    (void)childUsesTerminal; //unused
     assert_msg(false, "Not supported on WASI", 0);
 }
 
-__attribute__((noreturn))
+DEBUGNOTRETURN
 void SystemNative_GetControlCharacters(
     int32_t* controlCharacterNames, uint8_t* controlCharacterValues, int32_t controlCharacterLength,
     uint8_t* posixDisableValue)
@@ -77,10 +78,6 @@ void SystemNative_GetControlCharacters(
     assert(controlCharacterLength >= 0);
     assert(posixDisableValue != NULL);
 
-    (void)controlCharacterNames; //unused
-    (void)controlCharacterValues; //unused
-    (void)controlCharacterLength; //unused
-    (void)posixDisableValue; //unused
     assert_msg(false, "Not supported on WASI", 0);
 }
 

src/native/libs/System.Native/pal_dynamicload_wasi.c

@@ -12,7 +12,6 @@
 void* SystemNative_LoadLibrary(const char* filename)
 {
     assert_msg(false, "Not supported on WASI", 0);
-    (void)filename; // unused
     return NULL;
 }
 

src/native/libs/System.Native/pal_mount_wasi.c

@@ -11,17 +11,13 @@
 
 int32_t SystemNative_GetAllMountPoints(MountPointFound onFound, void* context)
 {
-    (void)onFound; // unused
-    (void)context; // unused
     return -1;
 }
 
 int32_t SystemNative_GetSpaceInfoForMountPoint(const char* name, MountPointInformation* mpi)
 {
     assert(name != NULL);
     assert(mpi != NULL);
-    (void)name; // unused
-    (void)mpi; // unused
     return -1;
 }
 
@@ -30,9 +26,5 @@ SystemNative_GetFormatInfoForMountPoint(const char* name, char* formatNameBuffer
 {
     assert((formatNameBuffer != NULL) && (formatType != NULL));
     assert(bufferLength > 0);
-    (void)name; // unused
-    (void)formatNameBuffer; // unused
-    (void)bufferLength; // unused
-    (void)formatType; // unused
     return -1;
 }

src/native/libs/System.Native/pal_process_wasi.c

@@ -17,6 +17,12 @@
 
 #include <minipal/getexepath.h>
 
+#ifdef DEBUG
+#define DEBUGNOTRETURN __attribute__((noreturn))
+#else
+#define DEBUGNOTRETURN
+#endif
+
 int32_t SystemNative_ForkAndExecProcess(const char* filename,
                                       char* const argv[],
                                       char* const envp[],
@@ -34,22 +40,6 @@ int32_t SystemNative_ForkAndExecProcess(const char* filename,
                                       int32_t* stdoutFd,
                                       int32_t* stderrFd)
 {
-    (void)filename; // unused
-    (void)argv; // unused
-    (void)envp; // unused
-    (void)cwd; // unused
-    (void)redirectStdin; // unused
-    (void)redirectStdout; // unused
-    (void)redirectStderr; // unused
-    (void)setCredentials; // unused
-    (void)userId; // unused
-    (void)groupId; // unused
-    (void)groups; // unused
-    (void)groupsLength; // unused
-    (void)childPid; // unused
-    (void)stdinFd; // unused
-    (void)stdoutFd; // unused
-    (void)stderrFd; // unused
     return -1;
 }
 
@@ -58,15 +48,12 @@ int32_t SystemNative_GetRLimit(RLimitResources resourceType, RLimit* limits)
     assert(limits != NULL);
     int result = -1;
     memset(limits, 0, sizeof(RLimit));
-    (void)resourceType; // unused
     return result;
 }
 
 int32_t SystemNative_SetRLimit(RLimitResources resourceType, const RLimit* limits)
 {
     assert(limits != NULL);
-    (void)resourceType; // unused
-    (void)limits; // unused
     return -1;
 }
 
@@ -85,13 +72,10 @@ int32_t SystemNative_GetSid(int32_t pid)
     return -1;
 }
 
-__attribute__((noreturn))
+DEBUGNOTRETURN
 void SystemNative_SysLog(SysLogPriority priority, const char* message, const char* arg1)
 {
     assert_msg(false, "Not supported on WASI", 0);
-    (void)priority; // unused
-    (void)message; // unused
-    (void)arg1; // unused
 }
 
 int32_t SystemNative_WaitIdAnyExitedNoHangNoWait(void)
@@ -101,30 +85,21 @@ int32_t SystemNative_WaitIdAnyExitedNoHangNoWait(void)
 
 int32_t SystemNative_WaitPidExitedNoHang(int32_t pid, int32_t* exitCode)
 {
-    (void)pid; // unused
-    (void)exitCode; // unused
     return -1;
 }
 
 int64_t SystemNative_PathConf(const char* path, PathConfName name)
 {
-    (void)path; // unused
-    (void)name; // unused
     return -1;
 }
 
 int32_t SystemNative_GetPriority(PriorityWhich which, int32_t who)
 {
-    (void)which; // unused
-    (void)who; // unused
     return -1;
 }
 
 int32_t SystemNative_SetPriority(PriorityWhich which, int32_t who, int32_t nice)
 {
-    (void)which; // unused
-    (void)who; // unused
-    (void)nice; // unused
     return -1;
 }
 
@@ -143,16 +118,12 @@ char* SystemNative_GetCwd(char* buffer, int32_t bufferSize)
 
 int32_t SystemNative_SchedSetAffinity(int32_t pid, intptr_t* mask)
 {
-    (void)pid;
-    (void)mask;
     errno = ENOTSUP;
     return -1;
 }
 
 int32_t SystemNative_SchedGetAffinity(int32_t pid, intptr_t* mask)
 {
-    (void)pid;
-    (void)mask;
     errno = ENOTSUP;
     return -1;
 }

src/native/libs/System.Native/pal_signal_wasi.c

@@ -14,53 +14,52 @@
 #include <sys/types.h>
 #include <unistd.h>
 
-__attribute__((noreturn))
+#ifdef DEBUG
+#define DEBUGNOTRETURN __attribute__((noreturn))
+#else
+#define DEBUGNOTRETURN
+#endif
+
+DEBUGNOTRETURN
 void SystemNative_SetPosixSignalHandler(PosixSignalHandler signalHandler)
 {
     assert(signalHandler);
-    (void)signalHandler;
     assert_msg(false, "Not supported on WASI", 0);
 }
 
-__attribute__((noreturn))
+DEBUGNOTRETURN
 void SystemNative_HandleNonCanceledPosixSignal(int32_t signalCode)
 {
-    (void)signalCode;
     assert_msg(false, "Not supported on WASI", 0);
 }
 
 
-__attribute__((noreturn))
+DEBUGNOTRETURN
 void SystemNative_SetTerminalInvalidationHandler(TerminalInvalidationCallback callback)
 {
     assert(callback != NULL);
     assert_msg(false, "Not supported on WASI", 0);
-    (void)callback;
 }
 
-__attribute__((noreturn))
+DEBUGNOTRETURN
 void SystemNative_RegisterForSigChld(SigChldCallback callback)
 {
     assert(callback != NULL);
     assert_msg(false, "Not supported on WASI", 0);
-    (void)callback;
 }
 
-__attribute__((noreturn))
+DEBUGNOTRETURN
 void SystemNative_SetDelayedSigChildConsoleConfigurationHandler(void (*callback)(void))
 {
     assert(callback == NULL);
     assert_msg(false, "Not supported on WASI", 0);
-    (void)callback;
 }
 
 int32_t SystemNative_EnablePosixSignalHandling(int signalCode)
 {
-    (void)signalCode;
     return false;
 }
 
 void SystemNative_DisablePosixSignalHandling(int signalCode)
 {
-    (void)signalCode;
 }

src/native/libs/System.Native/pal_threading_wasi.c

@@ -11,8 +11,11 @@
 #include <stdbool.h>
 #include <stdlib.h>
 
-////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
-// LowLevelMonitor - Represents a non-recursive mutex and condition
+#ifdef DEBUG
+#define DEBUGNOTRETURN __attribute__((noreturn))
+#else
+#define DEBUGNOTRETURN
+#endif
 
 struct LowLevelMonitor
 {
@@ -33,40 +36,31 @@ void SystemNative_LowLevelMonitor_Destroy(LowLevelMonitor* monitor)
 void SystemNative_LowLevelMonitor_Acquire(LowLevelMonitor* monitor)
 {
     assert(monitor != NULL);
-    (void)monitor; // unused in release build
 }
 
 void SystemNative_LowLevelMonitor_Release(LowLevelMonitor* monitor)
 {
     assert(monitor != NULL);
-    (void)monitor; // unused in release build
 }
 
 void SystemNative_LowLevelMonitor_Wait(LowLevelMonitor* monitor)
 {
     assert(monitor != NULL);
-    (void)monitor; // unused in release build
 }
 
 int32_t SystemNative_LowLevelMonitor_TimedWait(LowLevelMonitor *monitor, int32_t timeoutMilliseconds)
 {
     assert(timeoutMilliseconds >= 0);
-    (void)monitor; // unused in release build
-    (void)timeoutMilliseconds; // unused in release build
     return true;
 }
 
 void SystemNative_LowLevelMonitor_Signal_Release(LowLevelMonitor* monitor)
 {
     assert(monitor != NULL);
-    (void)monitor; // unused in release build
 }
 
 int32_t SystemNative_CreateThread(uintptr_t stackSize, void *(*startAddress)(void*), void *parameter)
 {
-    (void)stackSize;
-    (void)startAddress;
-    (void)parameter;
     return false;
 }
 
@@ -75,13 +69,13 @@ int32_t SystemNative_SchedGetCpu(void)
     return -1;
 }
 
-__attribute__((noreturn))
+DEBUGNOTRETURN
 void SystemNative_Exit(int32_t exitCode)
 {
     exit(exitCode);
 }
 
-__attribute__((noreturn))
+DEBUGNOTRETURN
 void SystemNative_Abort(void)
 {
     abort();