Skip to content

Wait for serverTask before asserting IsCompletedSuccessfully #79071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jozkee merged 2 commits into from
Dec 2, 2022
Merged

Wait for serverTask before asserting IsCompletedSuccessfully #79071

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11d5f14
Wait for serverTask before asserting IsCompletedSuccessfully
jozkee Dec 1, 2022
d5b16f2
Apply suggestions from code review
adamsitnik Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review
  • Loading branch information
@adamsitnik
adamsitnik authored Dec 2, 2022
commit d5b16f20f2e603b02ce0e0d53763882aa6a10038
2 changes: 1 addition & 1 deletion src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.CurrentUserOnly.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ public void Connection_UnderDifferentUsers_BehavesAsExpected(
{
// When CurrentUserOnly is only on client side and asks for ReadOnly access, the connection is not rejected
// but we get the UnauthorizedAccessException on the client regardless.
serverTask.Wait(10_000);
Assert.True(serverTask.Wait(TimeSpan.FromSeconds(10)));
Assert.True(serverTask.IsCompletedSuccessfully);
}
else
Expand Down