Use ArgumentNullException.ThrowIfNull and ObjectDisposedException.ThrowIf in more places #79096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-meta Issue Detailsnull
|
stephentoub
force-pushed
the
morethrowhelperuse
branch
from
e6edd67 to
65aaf15
Compare
MihaZupan
approved these changes
Dec 1, 2022
src/libraries/System.Private.CoreLib/src/System/Globalization/TimeSpanParse.cs
Outdated
Show resolved
Hide resolved
stephentoub
commented
Dec 2, 2022
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CryptoStream.cs
Outdated
Show resolved
Hide resolved
stephentoub
force-pushed
the
morethrowhelperuse
branch
2 times, most recently
from
e5ff404 to
45cf8b0
Compare
Contributor
|
Are we missing an analyzer for these code patterns or is it just not enabled? |
Member
Author
|
dotnet/roslyn-analyzers#6293, which is what found/fixed these. |
…owIf in more places
stephentoub
force-pushed
the
morethrowhelperuse
branch
from
45cf8b0 to
e102672
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.