Skip to content

Allow Base64Decoder to ignore space chars, add IsValid methods and tests #79334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
heathbm wants to merge 19 commits into from
Closed

Allow Base64Decoder to ignore space chars, add IsValid methods and tests #79334

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
6d72060
Allow Base64Decoder to ignore space chars, add IsValid methods and tests
heathbm Dec 7, 2022
35302b4
Address PR feedback regarding Base64.IsValid
heathbm Dec 8, 2022
837b4bd
Address PR feedback: General optimizations
heathbm Dec 13, 2022
9b3b581
Address PR feedback: Use vectorized decoding while enough src
heathbm Dec 14, 2022
9983889
Address PR feedback: General optimization
heathbm Dec 15, 2022
f389289
Address PR feedback: Optimize for whitespace (\r\n) every 76 bytes
heathbm Dec 20, 2022
8482bbd
Address PR feedback: Implement driver/worker pattern with original code
heathbm Dec 23, 2022
dca7ee6
Address PR feedback: Reuse existing decoding method with whitespace
heathbm Dec 24, 2022
fe32cd3
Merge branch 'main' into add-base64-is-valid
heathbm Jan 6, 2023
261885c
Address PR feedback: Remove redundant empty buffer check
heathbm Jan 8, 2023
fb9e8de
Address PR Feedback: Add missing magic constant comment
heathbm Jan 8, 2023
b68d36c
Address PR Feedback: Avoid validation logic duplication
heathbm Mar 2, 2023
689de25
Merge branch 'main' into add-base64-is-valid
heathbm Mar 2, 2023
745fd41
Throw Base64FormatException when whitespace should not be ignored
heathbm Mar 3, 2023
b35ce12
Adress PR feedback: Improve naming of Base64Validator.cs internals
heathbm Mar 10, 2023
5848058
Adress PR feedback: Add test to demonstrate extra whitespace is counted
heathbm Mar 10, 2023
7c022b0
Address PR feedback: avoid bound-check
heathbm Mar 14, 2023
04989b5
Address PR feedback: Base64.IsValid: Return when no more invalid chars
heathbm Mar 14, 2023
5007df7
Address PR feedback: Refactor Bas64.IsValid method
heathbm Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address PR feedback: Use vectorized decoding while enough src
  • Loading branch information
@heathbm
heathbm committed Dec 14, 2022
commit 9b3b5818a4d024c1bfd88b7f8fa0a5d15372fb93
Loading