-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[JIT] X64 - Extend emitter peephole optimization of eliminating unnecessary mov instructions
#79381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
88 commits
Select commit
Hold shift + click to select a range
f5feaeb
Added regUpper32BitsZeroLookup
TIHan 958a84f
Minor refactoring
TIHan 755461e
Refactoring
TIHan 95c7d09
Refactoring
TIHan 12e3c4f
Refactoring
TIHan b42682c
Added comments, more refactoring
TIHan 2d806a5
Added some logs
TIHan 2d5e07f
Added some logs
TIHan 4d06e05
Added some logs
TIHan 0c1599a
Added some logs
TIHan 53ecd41
Remove logs. Fixed an issue.
TIHan 0f42667
Expanding peephole opt even more. Trying to improve tp.
TIHan 2de6089
Some refactoring
TIHan bd3b211
Trying to make this safe
TIHan 9792d0f
work
TIHan 0ed30e9
more work
TIHan 3e452fd
Fixing a few issues
TIHan 126d6b5
Fixing a bug
TIHan 80ac0d7
Switching to a list of instrs
TIHan 9497d5e
Adding simple peephole API
TIHan 4ee489b
minor change
TIHan 7d599df
Trying to improve tp
TIHan 11a1709
Trying to improve tp
TIHan e33147a
Fixed a minor issue
TIHan 99cba5a
Small correctness issue
TIHan 0356348
Minor change
TIHan 2c10d21
Using emitCurIGinsCnt
TIHan 189afe0
Added EMIT_MAX_IG_INS_COUNT
TIHan f0e626a
Formatting
TIHan f1e7c07
Feedback
TIHan ca8813a
Feedback
TIHan c533d54
Feedback
TIHan e0df38e
Minor change
TIHan 1f5501a
More comments, minor change
TIHan e34367f
Get rid of these asserts
TIHan b2c0414
Improving TP even further
TIHan 5431a53
Added CalculateChecksumTest
TIHan 07ec7fb
Only allow GPR
TIHan 7e0079f
Update src/coreclr/jit/emitxarch.cpp
TIHan 0c71902
Feedback
TIHan 25cb4fb
Feedback
TIHan 7d6d03d
Merge remote-tracking branch 'upstream/main' into mov-elim-1
TIHan ee349d3
Updating last instructions when saving IG. Using 'min(emitCurIGinsCnt…
TIHan a2538ca
Added 'emitCurLastInsCnt'
TIHan 6fb2694
Remove commented code
TIHan 7e97320
Using 'emitCurLastInsCnt' for the ring buffer
TIHan 896a32a
Formatting
TIHan 49c3c07
Fix last instructions if the next IG is extended
TIHan f229bc0
Update emit.cpp
TIHan 920fc7c
Update emit.cpp
TIHan 7380971
Merged
TIHan a4e92c7
Fix build
TIHan fa4f6e5
Fix build
TIHan 0fd25ca
Fix build
TIHan 2ff99ed
Formatting
TIHan d2307d5
Fix assertion
TIHan f478d53
merging
TIHan 0afbc01
Fixed minor issue
TIHan 140fd11
Merging complete
TIHan 423a72f
Fix build
TIHan c6c5711
Added canPeepholeCrossIGBoundaries
TIHan cab9705
Cleanup
TIHan 987e50c
More cleanup
TIHan 453e00b
More cleanup
TIHan 710b039
More cleanup
TIHan cadbf4d
More cleanup
TIHan a68cd3f
More cleanup
TIHan 26cb484
Fix build
TIHan a88103a
Add count back
TIHan 5fe41e2
Formatting
TIHan c1b612f
Merge remote-tracking branch 'upstream/main' into mov-elim-1
TIHan 9f42790
Merge branch 'main' into mov-elim-1
TIHan 84f076c
Added back comments
TIHan 12ea52f
Turn off backwards nav for arm
TIHan cb3b2e8
Added debug check for backward nav checks
TIHan a007c3b
Remove debug check
TIHan 5e33fad
Merge remote-tracking branch 'upstream/main' into mov-elim-1
TIHan b35c10e
Feedback. Allow looking back at conditional ops.
TIHan 7576c94
Update src/coreclr/jit/emit.h
TIHan 6816216
Feedback
TIHan 3a4adfb
Feedback
TIHan 5a3acc5
Fix ordering
TIHan d48e429
Added regression test. div,idiv,mul,imul should be noted as write to …
TIHan 90479c5
Added another regression test
TIHan f7224c2
Actually added the regression test
TIHan 36ffb3a
Fix test
TIHan d1d7814
Merged
TIHan 8162a38
Fix merge
TIHan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Minor change
- Loading branch information
commit e0df38eb172458f042554ebb406e48a172cc34e4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.