Fix compression #79412
Merged
Fix compression #79412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #77783
|
stephentoub
reviewed
Dec 8, 2022
src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/ClientWebSocket.cs
Show resolved
Hide resolved
MihaZupan
approved these changes
Dec 8, 2022
Member
MihaZupan
left a comment
MihaZupan
left a comment
There was a problem hiding this comment.
A few style nits, otherwise LGTM
src/libraries/System.Net.WebSockets.Client/tests/DeflateTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.WebSockets.Client/tests/DeflateTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.WebSockets.Client/tests/DeflateTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.WebSockets.Client/tests/DeflateTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.WebSockets.Client/tests/DeflateTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Miha Zupan <[email protected]>
CarnaViire
reviewed
Dec 9, 2022
src/libraries/System.Net.WebSockets.Client/tests/DeflateTests.cs
Outdated
Show resolved
Hide resolved
CarnaViire
reviewed
Dec 9, 2022
src/libraries/System.Net.WebSockets.Client/tests/DeflateTests.cs
Outdated
Show resolved
Hide resolved
CarnaViire
approved these changes
Dec 12, 2022
Member
|
/backport to release/7.0 |
Contributor
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3677977293 |
Member
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/3678041224 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77783