Skip to content

Report FOH segments #79985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cshung wants to merge 1 commit into from
Closed

Report FOH segments #79985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/coreclr/debug/daccess/dacimpl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1326,6 +1326,8 @@ class ClrDataAccess
HRESULT EnumMemDumpAppDomainInfo(CLRDataEnumMemoryFlags flags);
HRESULT EnumMemDumpAllThreadsStack(CLRDataEnumMemoryFlags flags);
HRESULT EnumMemCLRMainModuleInfo();
HRESULT EnumMemCollectFrozenHeap();
HRESULT EnumMemCollectFrozenSegments(CLRDATA_ADDRESS segment);

bool ReportMem(TADDR addr, TSIZE_T size, bool fExpectSuccess = true);
bool DacUpdateMemoryRegion(TADDR addr, TSIZE_T bufferSize, BYTE* buffer);
Expand Down
54 changes: 54 additions & 0 deletions src/coreclr/debug/daccess/enummem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,9 @@ HRESULT ClrDataAccess::EnumMemoryRegionsWorkerHeap(IN CLRDataEnumMemoryFlags fla
// Dump the Debugger object data needed
CATCH_ALL_EXCEPT_RETHROW_COR_E_OPERATIONCANCELLED( g_pDebugger->EnumMemoryRegions(flags); )

// Dump the frozen segments
CATCH_ALL_EXCEPT_RETHROW_COR_E_OPERATIONCANCELLED ( status = EnumMemCollectFrozenHeap(); );

// now dump the memory get dragged in by using DAC API implicitly.
m_dumpStats.m_cbImplicitly = m_instances.DumpAllInstances(m_enumMemCb);

Expand Down Expand Up @@ -1582,6 +1585,57 @@ HRESULT ClrDataAccess::EnumMemCLRMainModuleInfo()
return status;
}

HRESULT ClrDataAccess::EnumMemCollectFrozenHeap()
{
SUPPORTS_DAC;

HRESULT hr = S_OK;

struct DacpGcHeapData heap;
IfFailRet(GetGCHeapData(&heap));
if (heap.bServerMode)
{
unsigned int heapCount = GCHeapCount();
CLRDATA_ADDRESS* heaps = (CLRDATA_ADDRESS*)alloca(heapCount * sizeof(CLRDATA_ADDRESS*));
IfFailRet(GetServerHeaps(heaps, m_pTarget));
for (unsigned int heapNum = 0; heapNum < heapCount; heapNum++)
{
struct DacpGcHeapDetails heap_detail;
IfFailRet(ServerGCHeapDetails(heaps[heapNum], &heap_detail));
IfFailRet(EnumMemCollectFrozenSegments(heap_detail.generation_table[2].start_segment));
}
}
else
{
struct DacpGcHeapDetails heap_detail;
IfFailRet(GetGCHeapStaticData(&heap_detail));
IfFailRet(EnumMemCollectFrozenSegments(heap_detail.generation_table[2].start_segment));
}

return hr;
}

HRESULT ClrDataAccess::EnumMemCollectFrozenSegments(CLRDATA_ADDRESS segment)
{
SUPPORTS_DAC;

HRESULT hr = S_OK;

const size_t heap_segment_flags_readonly = 1;

while (segment)
{
struct DacpHeapSegmentData heap_segment;
IfFailRet(GetHeapSegmentData(segment, &heap_segment));
if (heap_segment.flags & heap_segment_flags_readonly)
{
ReportMem((TADDR)heap_segment.mem, (TSIZE_T)(heap_segment.allocated - heap_segment.mem));
}
segment = heap_segment.next;
}

return hr;
}

//++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
//
Expand Down