Skip to content

[release/7.0] Remove page map from PAL virtual memory allocator #80173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 2 commits into from
Jan 5, 2023
Merged

[release/7.0] Remove page map from PAL virtual memory allocator #80173

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8b1efe
Remove page map from PAL virtual memory allocator
janvorli Dec 13, 2022
d2c2334
Fix bug introduced by page bitmap removal
janvorli Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix bug introduced by page bitmap removal 
The page bitmap removal in PAL that was made recently has introduced
a subtle bug when the `VIRTUALCommitMemory` was returning incorrect
address when a region of memory was reserved and later a smaller
subset of that region that didn't start at the beginning of the
reserved region was committed. It was returning the address of
the originally reserved region.

While we have not hit any issues in the main branch, a backport
of this change has caused CI failures on macOS due to the issue.
  • Loading branch information
@janvorli
janvorli committed Jan 5, 2023
commit d2c2334f4a085a5ca38e22dccfd325bfd7f6260b
2 changes: 1 addition & 1 deletion src/coreclr/pal/src/map/virtual.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,7 +768,7 @@ VIRTUALCommitMemory(
madvise((void *) StartBoundary, MemSize, MADV_DODUMP);
#endif

pRetVal = (void *) (pInformation->startBoundary);
pRetVal = (void *) StartBoundary;
goto done;

error:
Expand Down