React to aspnetcore analyzers

src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Handlers/DeflateHandler.cs

@@ -13,8 +13,8 @@ public static async Task InvokeAsync(HttpContext context)
         {
             string responseBody = "Sending DEFLATE compressed";
 
-            context.Response.Headers.Add("Content-MD5", Convert.ToBase64String(ContentHelper.ComputeMD5Hash(responseBody)));
-            context.Response.Headers.Add("Content-Encoding", "deflate");
+            context.Response.Headers["Content-MD5"] = Convert.ToBase64String(ContentHelper.ComputeMD5Hash(responseBody));
+            context.Response.Headers["Content-Encoding"] = "deflate";
 
             context.Response.ContentType = "text/plain";
 

src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Handlers/EchoHandler.cs

@@ -21,7 +21,7 @@ public static async Task InvokeAsync(HttpContext context)
             }
 
             // Add original request method verb as a custom response header.
-            context.Response.Headers.Add("X-HttpRequest-Method", context.Request.Method);
+            context.Response.Headers["X-HttpRequest-Method"] = context.Request.Method;
 
             // Echo back JSON encoded payload.
             RequestInformation info = await RequestInformation.CreateAsync(context.Request);
@@ -34,7 +34,7 @@ public static async Task InvokeAsync(HttpContext context)
                 byte[] hash = md5.ComputeHash(bytes);
                 string encodedHash = Convert.ToBase64String(hash);
 
-                context.Response.Headers.Add("Content-MD5", encodedHash);
+                context.Response.Headers["Content-MD5"] = encodedHash;
                 context.Response.ContentType = "application/json";
                 context.Response.ContentLength = bytes.Length;
                 await context.Response.Body.WriteAsync(bytes, 0, bytes.Length);

src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Handlers/GZipHandler.cs

@@ -13,8 +13,8 @@ public static async Task InvokeAsync(HttpContext context)
         {
             string responseBody = "Sending GZIP compressed";
 
-            context.Response.Headers.Add("Content-MD5", Convert.ToBase64String(ContentHelper.ComputeMD5Hash(responseBody)));
-            context.Response.Headers.Add("Content-Encoding", "gzip");
+            context.Response.Headers["Content-MD5"] = Convert.ToBase64String(ContentHelper.ComputeMD5Hash(responseBody));
+            context.Response.Headers["Content-Encoding"] = "gzip";
 
             context.Response.ContentType = "text/plain";
 

src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Handlers/LargeResponse.cs

@@ -21,7 +21,7 @@ public static async Task InvokeAsync(HttpContext context)
             }
 
             // Add original request method verb as a custom response header.
-            context.Response.Headers.Add("X-HttpRequest-Method", context.Request.Method);
+            context.Response.Headers["X-HttpRequest-Method"] = context.Request.Method;
 
             var size = 1024;
             if (context.Request.Query.TryGetValue("size", out var value))

src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Handlers/RedirectHandler.cs

@@ -60,15 +60,13 @@ public static void Invoke(HttpContext context)
 
             if (hops <= 1)
             {
-                context.Response.Headers.Add("Location", redirectUri);
+                context.Response.Headers["Location"] = redirectUri;
             }
             else
             {
-                context.Response.Headers.Add(
-                    "Location",
-                    string.Format("/Redirect.ashx?uri={0}&hops={1}",
+                context.Response.Headers["Location"] = string.Format("/Redirect.ashx?uri={0}&hops={1}",
                     redirectUri,
-                    hops - 1));
+                    hops - 1);
             }
 
             context.Response.StatusCode = statusCode;

src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Handlers/TestHandler.cs

@@ -28,7 +28,7 @@ public static async Task InvokeAsync(HttpContext context)
             byte[] bytes = Encoding.ASCII.GetBytes(echoJson);
             var hash = md5.ComputeHash(bytes);
             string encodedHash = Convert.ToBase64String(hash);
-            context.Response.Headers.Add("Content-MD5", encodedHash);
+            context.Response.Headers["Content-MD5"] = encodedHash;
 
             RequestInformation newEcho = RequestInformation.DeSerializeFromJson(echoJson);
             context.Response.ContentType = "text/plain"; //"application/json";

src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Handlers/VerifyUploadHandler.cs

@@ -14,19 +14,19 @@ public class VerifyUploadHandler
         public static async Task InvokeAsync(HttpContext context)
         {
             // Report back original request method verb.
-            context.Response.Headers.Add("X-HttpRequest-Method", context.Request.Method);
+            context.Response.Headers["X-HttpRequest-Method"] = context.Request.Method;
 
             // Report back original entity-body related request headers.
             string contentLength = context.Request.Headers["Content-Length"];
             if (!string.IsNullOrEmpty(contentLength))
             {
-                context.Response.Headers.Add("X-HttpRequest-Headers-ContentLength", contentLength);
+                context.Response.Headers["X-HttpRequest-Headers-ContentLength"] = contentLength;
             }
 
             string transferEncoding = context.Request.Headers["Transfer-Encoding"];
             if (!string.IsNullOrEmpty(transferEncoding))
             {
-                context.Response.Headers.Add("X-HttpRequest-Headers-TransferEncoding", transferEncoding);
+                context.Response.Headers["X-HttpRequest-Headers-TransferEncoding"] = transferEncoding;
             }
 
             // Get request body.

src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Helpers/AuthenticationHelper.cs

@@ -49,7 +49,7 @@ private static bool HandleBasicAuthentication(HttpContext context, string user,
             if (authHeader == null)
             {
                 context.Response.StatusCode = 401;
-                context.Response.Headers.Add("WWW-Authenticate", WwwAuthenticateHeaderValue);
+                context.Response.Headers["WWW-Authenticate"] = WwwAuthenticateHeaderValue;
                 return false;
             }
 
@@ -82,7 +82,7 @@ private static bool HandleBasicAuthentication(HttpContext context, string user,
             if (pair.Length != 2 || pair[0] != user || pair[1] != password)
             {
                 context.Response.StatusCode = 401;
-                context.Response.Headers.Add("WWW-Authenticate", WwwAuthenticateHeaderValue);
+                context.Response.Headers["WWW-Authenticate"] = WwwAuthenticateHeaderValue;
                 return false;
             }
 
@@ -100,7 +100,7 @@ private static bool HandleChallengeResponseAuthentication(
             if (authHeader == null)
             {
                 context.Response.StatusCode = 401;
-                context.Response.Headers.Add("WWW-Authenticate", authType);
+                context.Response.Headers["WWW-Authenticate"] = authType;
                 return false;
             }
 

src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Helpers/RequestHelper.cs

@@ -18,7 +18,7 @@ public static void AddResponseCookies(HttpContext context)
             {
                 if (string.Equals(pair.Key, "X-SetCookie", StringComparison.OrdinalIgnoreCase))
                 {
-                    context.Response.Headers.Add("Set-Cookie", pair.Value.ToString());
+                    context.Response.Headers["Set-Cookie"] = pair.Value.ToString();
                 }
             }
         }