Restore Advance when reading float/double with XmlBufferReader. #80274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng on not-my-machine.
Member
|
LGTM |
Member
Author
|
/backport to release/7.0 |
Contributor
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3859564678 |
stephentoub
approved these changes
Jan 7, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring back buffer advance when reading float/double in XmlBufferReader.
Towards the end of 7.0, we took a change (#73332) to improve the performance of XmlDictionaryReader. This change both brought to light some Big-Endian issues in DCS, as well as obscured the fact that some methods for reading double/single with XmlBufferReader required intentional advancing of the buffer after reading. A later change to fix the Big-Endian-ness (#74599) missed those advances.
(#74599 was recently manually backported to 6.0 as well, but as 6.0 did not have the perf change that obscured the calls to Advance, they were not lost in that backport.)
Fix #78913