Skip to content

Implement Startup hooks support in Mono #80391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lambdageek merged 17 commits into from
Jan 18, 2023
Merged

Implement Startup hooks support in Mono #80391

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
04bae4a
Implement startup hooks support in Mono
lambdageek Jan 9, 2023
c5ecf6a
Keep StartupHookProvider.ProcessStartupHooks under feature flag
lambdageek Jan 10, 2023
b1f9182
Don't catch/cleanup the exceptions from startup hooks.
lambdageek Jan 10, 2023
05a7392
Add an ios simulator startup hook functional test
lambdageek Jan 10, 2023
c8e2c3b
Only initialize RuntimeEventSource if perftracing is supported
lambdageek Jan 10, 2023
bd46541
Actually implement the ios startup hook test
lambdageek Jan 10, 2023
27cc89b
Implement Android functional test
lambdageek Jan 11, 2023
df74740
Add WASM functional test
lambdageek Jan 11, 2023
a889f7d
Make RuntimeEventSource.Initialize safe to call multiple times
lambdageek Jan 12, 2023
9f41c60
Revert "Make RuntimeEventSource.Initialize safe to call multiple times"
lambdageek Jan 13, 2023
2cf970e
coreclr: Call RuntimeEventSource.Initialize from EventPipeAdapter::Fi…
lambdageek Jan 13, 2023
664f901
Call RuntimeEventSource.Initialize only if EventSource.IsSupported
lambdageek Jan 13, 2023
7d830fa
fix line damage
lambdageek Jan 13, 2023
a02cf40
more whitespace
lambdageek Jan 13, 2023
53f042c
Make a single managed startup method for CoreCLR
lambdageek Jan 13, 2023
b9d869e
fix build and line damage
lambdageek Jan 13, 2023
3fddf4f
fixup
lambdageek Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't catch/cleanup the exceptions from startup hooks.
  • Loading branch information
@lambdageek
lambdageek committed Jan 17, 2023
commit b1f91825f1043746369070fb703afdaa447a3d8e
4 changes: 2 additions & 2 deletions src/mono/mono/metadata/object.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8139,8 +8139,8 @@ mono_runtime_run_startup_hooks (void)
if (!method)
return;
mono_runtime_invoke_checked (method, NULL, NULL, error);
// FIXME: the design doc says exceptions should terminate the host app.
mono_error_cleanup (error);
// runtime hooks design doc says not to catch exceptions from the hooks
mono_error_raise_exception_deprecated (error);
}

#if NEVER_DEFINED
Expand Down