Skip to content

Fix Configuration to ensure calling the property setters. #80438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarekgh merged 2 commits into from
Jan 12, 2023
Merged

Fix Configuration to ensure calling the property setters. #80438

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5feef62
Fix Configuration to ensure calling the property setters.
tarekgh Jan 10, 2023
5c3c6fa
Address the feedback
tarekgh Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address the feedback
  • Loading branch information
@tarekgh
tarekgh committed Jan 11, 2023
commit 5c3c6fa645168d68d1b91bbb4550659695aa361f
13 changes: 4 additions & 9 deletions src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,10 @@ private static void BindProperty(PropertyInfo property, object instance, IConfig
config.GetSection(GetPropertyName(property)),
options);

if (propertyBindingPoint.HasNewValue)
// For property binding, there are some cases when HasNewValue is not set in BindingPoint while a non-null Value inside that object can be retrieved from the property getter.
// As example, when binding a property which not having a configuration entry matching this property and the getter can initialize the Value.
// It is important to call the property setter as the setters can have a logic adjusting the Value.
if (!propertyBindingPoint.IsReadOnly && propertyBindingPoint.Value is not null)
{
property.SetValue(instance, propertyBindingPoint.Value);
}
Expand Down Expand Up @@ -384,14 +387,6 @@ private static void BindInstance(
}
}
}

if (!bindingPoint.HasNewValue && !bindingPoint.IsReadOnly && bindingPoint.Value is not null)
{
// For property binding, there are some cases when HasNewValue is not set in BindingPoint while a non-null Value inside that object can be retrieved
// from the property getter. As example, when binding a property which not having a configuration entry matching this property and the getter can initialize the Value.
// It is important to set the HasNewValue to true at this time to force the property setter to run. The reason is the setters can have a logic adjusting the Value.
bindingPoint.SetValue(bindingPoint.Value);
}
}

[RequiresDynamicCode(DynamicCodeWarningMessage)]
Expand Down