[release/6.0] Invalidate buffered data when bypassing the cache #80554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsBackport of #80432 to release/6.0 Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
stephentoub
approved these changes
Jan 12, 2023
leecow
added
Servicing-approved
Contributor
|
Approved by Tactics (6.0.14).
Ready to merge. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #80432 to release/6.0
Customer Impact
Customers who are using
FileStream.ReadAsyncwith buffering enabled (the default) might read incorrect data. It's a silent error, but the "good thing" about this bug is that it's really hard to reproduce (a very specific sequence of reads and backward seeks need to be performed).Testing
Automated tests were added, and they are passing. Additional local validation against repro provided by the customer has confirmed that the bug is gone.
Risk
Very low, the change simply invalidates the cache at the right time.
No OOB changes needed for System.IO.FileSystem or System.Private.CoreLib.