Skip to content

Conversation

@tlakollo
Copy link
Contributor

@tlakollo tlakollo commented Jan 13, 2023

The current version has a bug that prevents the illink package to generate valid IL.
The Microsoft.NET.ILLink.Tasks package is blocking runtime to SDK flow
There is a PR #80429 that updates the cecil dependency into runtime but its blocked due to failures (there is 10 different repos trying to be updated at the same time)

…vents the illink package to generate valid IL.
@tlakollo tlakollo added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Jan 13, 2023
@tlakollo tlakollo added this to the 8.0.0 milestone Jan 13, 2023
@tlakollo tlakollo self-assigned this Jan 13, 2023
@ghost
Copy link

ghost commented Jan 13, 2023

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

The current version has a bug that prevents the illink package to generate valid IL.
The Microsoft.NET.ILLink.Tasks package is blocking runtime to SDK flow
There is a PR #80429 but its blocked due to failures

Author: tlakollo
Assignees: tlakollo
Labels:

area-Tools-ILLink

Milestone: 8.0.0

@tlakollo
Copy link
Contributor Author

@dotnet/runtime-infrastructure is it ok to manually update this dependency?

@MichalStrehovsky
Copy link
Member

You'd also need to update the version in Versions.props. The Version.Details.xml doesn't do anything based on my past experience.

@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 13, 2023

#80429 should now be unblocked and could be merged into main in roughly 3 hours. Let's wait for that one to avoid a merge conflict.

There is 10 different repos trying to be updated at the same time

Usually those dependency updates are less noisy, i.e. runtime-assets or hotreload-utils, etc. But we also batched roslyn updates into it and those are more complex and create more noise from what I perceived in the last weeks. I just changed that so that roslyn updates open a separate PR.

@ViktorHofer
Copy link
Member

Closing in favor of #80429

@tlakollo tlakollo deleted the ManualCecilUpdate branch January 13, 2023 15:43
@ghost ghost locked as resolved and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Tools-ILLink .NET linker development as well as trimming analyzers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants