Skip to content

[NativeAOT] correctly initalize CONTEXT before failing fast #81010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 7 commits into from
Feb 6, 2023
Merged

[NativeAOT] correctly initalize CONTEXT before failing fast #81010

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
667caac
[NativeAOT] correctly initalize CONTEXT before failing fast
AustinWise Jan 23, 2023
f29268e
Switch from using GetThreadContext to RtlCaptureContext.
AustinWise Jan 27, 2023
cebd1c0
Add a better explination of why the function is unimplmented on Unix.
AustinWise Jan 27, 2023
7d79927
Update src/coreclr/nativeaot/Runtime/PalRedhawk.h
AustinWise Jan 27, 2023
5f2ba0d
Respond to feedback: unconditionally set CONTEXT_CONTROL
AustinWise Jan 31, 2023
81a3d40
Respond to feedback: consolidate setting of ContextFlags.
AustinWise Jan 31, 2023
dc8c3ad
On second thought, don't add a second layer of ifdef nesting.
AustinWise Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Switch from using GetThreadContext to RtlCaptureContext.
  • Loading branch information
@AustinWise
AustinWise committed Jan 27, 2023
commit f29268efb0688a90aa0e562bf55656a840373085
9 changes: 1 addition & 8 deletions src/coreclr/nativeaot/Runtime/windows/PalRedhawkMinWin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,16 +449,9 @@ REDHAWK_PALEXPORT void REDHAWK_PALAPI PalRestoreContext(CONTEXT * pCtx)
REDHAWK_PALIMPORT bool REDHAWK_PALAPI TryPopulateControlSegmentRegisters(CONTEXT* pContext)
{
#if defined(TARGET_X86) || defined(TARGET_AMD64)
HANDLE hThread = GetCurrentThread();

CONTEXT ctx;
memset(&ctx, 0, sizeof(ctx));
ctx.ContextFlags = CONTEXT_CONTROL;

if (!GetThreadContext(hThread, &ctx))
{
return false;
}
RtlCaptureContext(&ctx);

pContext->SegCs = ctx.SegCs;
pContext->SegSs = ctx.SegSs;
Expand Down