Skip to content

Fix Configuration Binding with Instantiated Objects #81050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarekgh merged 9 commits into from
Jan 26, 2023
+243 −45
Merged

Fix Configuration Binding with Instantiated Objects #81050

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8d7d920
Fix Configuration Binding with Instantiated Objects
tarekgh Jan 23, 2023
1493935
Add Extra test
tarekgh Jan 23, 2023
ea81eba
Fix test build break
tarekgh Jan 23, 2023
a7761d5
Scoping the fix to settable collections only
tarekgh Jan 24, 2023
36c25ca
Address the feedback
tarekgh Jan 24, 2023
438a77c
Add log messages to the test to get more info about CI failure
tarekgh Jan 25, 2023
b8c73f9
Add logs to test
tarekgh Jan 25, 2023
4f7a43c
Exclude ISET<T> from the test trimming
tarekgh Jan 25, 2023
c047d04
Fix the trimming file to point at correct assembly
tarekgh Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix the trimming file to point at correct assembly
  • Loading branch information
@tarekgh
tarekgh committed Jan 26, 2023
commit c047d04edc9e998e7a7f0918e5a706747511272a
5 changes: 4 additions & 1 deletion src/libraries/Microsoft.Extensions.Configuration.Binder/tests/ILLink.Descriptors.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
<type fullname="System.Collections.Generic.HashSet`1">
<method signature="System.Void .ctor()" />
</type>
<type fullname="System.Collections.Generic.ISet`1" preserve="methods" />
</assembly>

<assembly fullname="System.Private.Corelib">
   <type fullname="System.Collections.Generic.ISet`1" preserve="methods" />
</assembly>
</linker>