Skip to content

[Android] Enable two networking tests #81895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonrozsival merged 3 commits into from
Feb 10, 2023
Merged

[Android] Enable two networking tests #81895

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0388926
Avoid crashing when AndroidCryptoNative_RegisterRemoteCertificateVali…
simonrozsival Feb 6, 2023
c2ab714
Enable GetAsync_IPv6LinkLocalAddressUri_Success test on Android
simonrozsival Feb 6, 2023
45f22fb
Enable supported cases of SslStream_ServerCallbackNotSet_UsesLocalCer…
simonrozsival Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Enable supported cases of SslStream_ServerCallbackNotSet_UsesLocalCer… 
…tificateSelection on Android
  • Loading branch information
@simonrozsival
simonrozsival committed Feb 9, 2023
commit 45f22fb6f0415409eb6d3e157e8737e781ef6f26
8 changes: 6 additions & 2 deletions src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamSniTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@

using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Net.Test.Common;
using System.Security.Authentication;
using System.Security.Cryptography.X509Certificates;
using System.Threading;
using System.Threading.Tasks;
using Xunit;
using Microsoft.DotNet.XUnitExtensions;

namespace System.Net.Security.Tests
{
Expand Down Expand Up @@ -94,11 +96,13 @@ public async Task SslStream_ServerCallbackAndLocalCertificateSelectionSet_Throws
}
}

[Theory]
[ConditionalTheory]
[MemberData(nameof(HostNameData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/68206", TestPlatforms.Android)]
public async Task SslStream_ServerCallbackNotSet_UsesLocalCertificateSelection(string hostName)
{
if (PlatformDetection.IsAndroid && hostName.ToCharArray().Any(c => !char.IsAscii(c)))
throw new SkipTestException("Android does not support non-ASCII host names");

using X509Certificate serverCert = Configuration.Certificates.GetSelfSignedServerCertificate();

int timesCallbackCalled = 0;
Expand Down