Skip to content

[android][ios] Add LibraryBuilder task to support aot library mode #81919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steveisok merged 31 commits into from
Mar 6, 2023
Merged

[android][ios] Add LibraryBuilder task to support aot library mode #81919

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
1d8483b
Apple side of the library builder
Jan 11, 2023
6cc724f
Embed framework through cmake on iOS. Add android fragments
Jan 12, 2023
bbf6992
Android library build
Jan 18, 2023
0055975
Bring back android exports
Jan 19, 2023
76cdbe4
Fix android library build by getting rid of force_load as that is onl…
Jan 21, 2023
9caea1f
Merge remote-tracking branch 'upstream/main' into lib-builder-mobile
Jan 24, 2023
9c3d805
Android builds library in separate cmake. iOS does too, but there are…
Feb 1, 2023
37fde1a
Add ability to pass in library projects to the main app
Feb 6, 2023
e3d1fd4
Clean up Android and scale back iOS to just building the library.
Feb 8, 2023
3911d2c
Merge remote-tracking branch 'upstream/main' into lib-builder-mobile
Feb 8, 2023
9bb0dd9
Move symbol table stripping to its own method
Feb 8, 2023
4ed46bf
Revert aotcompiler.c workaround
Feb 8, 2023
fde2bda
Condition some of the library builder specific items
Feb 8, 2023
d6fd785
Cleanup
Feb 9, 2023
cde3f9d
Add library builder tasks as a correlation payload.
Feb 10, 2023
6ba6aa9
Remove unnecessary librarybuilder props import
Feb 10, 2023
ba37138
Feedback
Feb 13, 2023
d3c03ac
Make sure sample provides linker arg items
Feb 14, 2023
04acf6c
Linker args in runtime test build
Feb 14, 2023
f4c204f
Merge remote-tracking branch 'upstream/main' into lib-builder-mobile
Feb 22, 2023
2ccf282
Make the runtime libraries to link actually work
Feb 23, 2023
807844e
Add default list of pinvokes for android aot
Feb 23, 2023
55e98f5
Merge remote-tracking branch 'upstream/main' into lib-builder-mobile
Feb 28, 2023
340a02f
Feedback
Feb 28, 2023
09aab3c
Remove extra symbols to keep. Condition direct icalls and direct pinv…
Mar 1, 2023
c99889b
PR feedback. Add test UnmanagedCallersOnly back in
Mar 1, 2023
223cf3a
Remove autoinit.c as it will come back in a follow up
Mar 1, 2023
e641c28
Generate list of assemblies that contained unmanagedcallersonly attri…
Mar 4, 2023
6a23439
More feedback
Mar 6, 2023
e272bb0
Merge remote-tracking branch 'upstream/main' into lib-builder-mobile
Mar 6, 2023
f30804d
Ignore CA1850 in the library builder
Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move symbol table stripping to its own method
  • Loading branch information
Steve Pfister committed Feb 8, 2023
commit 9bb0dd970fb32e4a6cd044a93f6339a0e980f9e7
1 change: 1 addition & 0 deletions src/mono/msbuild/common/LibraryBuilder.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
Condition="'$(RunAOTCompilation)' == 'true'">

<PropertyGroup>
<_IsSharedLibrary>false</_IsSharedLibrary>
<_IsSharedLibrary Condition="'$(NativeLib)' == 'shared'">true</_IsSharedLibrary>
</PropertyGroup>

Expand Down
7 changes: 6 additions & 1 deletion src/tasks/AppleAppBuilder/AppleAppBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,9 +330,14 @@ public override bool Execute()
}
else
{
string appDir = generator.BuildAppBundle(XcodeProjectPath, Optimized, StripSymbolTable, DevTeamProvisioning);
string appDir = generator.BuildAppBundle(XcodeProjectPath, Optimized, DevTeamProvisioning);
AppBundlePath = Xcode.GetAppPath(appDir, XcodeProjectPath);

if (StripSymbolTable)
{
generator.StripApp(XcodeProjectPath, AppBundlePath);
}

generator.LogAppSize(AppBundlePath);
}
}
Expand Down
8 changes: 4 additions & 4 deletions src/tasks/AppleAppBuilder/Xcode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,15 +110,15 @@ public string TargetOS
public override bool Execute()
{
Xcode project = new Xcode(Log, TargetOS, Arch);
string appDir = project.BuildAppBundle(XcodeProjectPath, Optimized, StripSymbolTable, DevTeamProvisioning);
string appDir = project.BuildAppBundle(XcodeProjectPath, Optimized, DevTeamProvisioning);

string appPath = Xcode.GetAppPath(appDir, XcodeProjectPath);
string newAppPath = Xcode.GetAppPath(DestinationFolder!, XcodeProjectPath);
Directory.Move(appPath, newAppPath);

if (StripSymbolTable)
{
project.StripApp(newAppPath);
project.StripApp(XcodeProjectPath, newAppPath);
}

project.LogAppSize(newAppPath);
Expand Down Expand Up @@ -511,7 +511,7 @@ public string GenerateCMake(
}

public string BuildAppBundle(
string xcodePrjPath, bool optimized, bool stripSymbolTable, string? devTeamProvisioning = null)
string xcodePrjPath, bool optimized, string? devTeamProvisioning = null)
{
string sdk;
var args = new StringBuilder();
Expand Down Expand Up @@ -619,7 +619,7 @@ public void LogAppSize(string appPath)
Logger.LogMessage(MessageImportance.High, $"\nAPP size: {(appSize / 1000_000.0):0.#} Mb.\n");
}

public void StripApp(string appPath)
public void StripApp(string xcodePrjPath, string appPath)
{
string filename = Path.GetFileNameWithoutExtension(appPath);
Utils.RunProcess(Logger, "dsymutil", $"{appPath}/{filename} -o {Path.GetDirectoryName(xcodePrjPath)}/{filename}.dSYM", workingDir: Path.GetDirectoryName(appPath));
Expand Down