JIT: in minimal profiling mode, ignore impact of conditional throws #81972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omit edge probes inspired by throw blocks, if a method can also return normally. In reconstruction, we will just assume those throws never happen. For simple methods this effectively reduces them to straight-line flow and we can then omit all probes.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsOmit edge probes inspired by throw blocks, if a method can also return normally. In reconstruction, we will just assume those throws never happen. For simple methods this effectively reduces them to straight-line flow and we can then omit all probes.
|
Member
Author
|
@EgorBo PTAL Some (spurious) regression diffs in Tier0 where SPMI returns the fake instrumentation address. |
EgorBo
approved these changes
Feb 10, 2023
This was referenced Feb 10, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omit edge probes inspired by throw blocks, if a method can also return normally. In reconstruction, we will just assume those throws never happen.
For simple methods this effectively reduces them to straight-line flow and we can then omit all probes.
Diffs