Skip to content

RegularExpressions.Tests: match MicrosoftCodeAnalysisVersion used by RegularExpressions.Generator when DotNetBuildFromSource. #82036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ViktorHofer merged 2 commits into from
Feb 14, 2023
Merged

RegularExpressions.Tests: match MicrosoftCodeAnalysisVersion used by RegularExpressions.Generator when DotNetBuildFromSource. #82036

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
664672b
RegularExpressions.Tests: match MicrosoftCodeAnalysisVersion used by …
tmds Feb 13, 2023
06e86a7
RegularExpressions.Tests: remove pinned version for MicrosoftCodeAnal…
tmds Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...Text.RegularExpressions/tests/FunctionalTests/System.Text.RegularExpressions.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<IsHighAotMemoryUsageTest>true</IsHighAotMemoryUsageTest> <!-- to avoid OOMs with source generation in wasm: https://github.com/dotnet/runtime/pull/60701 -->

<!-- Remove once the repo moves to a sufficiently high-enough version for file-scoped types -->
<MicrosoftCodeAnalysisVersion>4.4.0-1.22356.23</MicrosoftCodeAnalysisVersion>
<MicrosoftCodeAnalysisVersion Condition="'$(DotNetBuildFromSource)' != 'true'">4.4.0-1.22356.23</MicrosoftCodeAnalysisVersion>
Copy link
Member Author

@tmds tmds Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got file-scoped types with .NET 7. Is this property still needed?

Copy link
Member Author

@tmds tmds Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @stephentoub

Copy link
Member

@stephentoub stephentoub Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't be needed anymore.


</PropertyGroup>
<ItemGroup>
Expand Down