Skip to content

Try reducing memory pressure during object writing #83181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichalStrehovsky merged 5 commits into from
Mar 9, 2023
Merged

Try reducing memory pressure during object writing #83181

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ba2d420
Try reducing memory pressure during object writing
MichalStrehovsky Mar 9, 2023
0038b53
Update ObjectWriter.cs
MichalStrehovsky Mar 9, 2023
13bc604
Apply suggestions from code review
MichalStrehovsky Mar 9, 2023
42bc053
Update ObjectWriter.cs
MichalStrehovsky Mar 9, 2023
7ba41c0
Update ObjectWriter.cs
MichalStrehovsky Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/ObjectWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1150,14 +1150,30 @@ public static void EmitObject(string objectFilePath, IReadOnlyCollection<Depende
}

if (logger.IsVerbose)
logger.LogMessage($"Finalizing output to '{objectFilePath}'...");
logger.LogMessage($"Emitting debug information");

// Native side of the object writer is going to do more native memory allocations.
// Free up as much memory as possible so that we don't get OOM killed.
// This is potentially a waste of time. We're about to end the process and let the
// OS "garbage collect" the entire address space.
var gcMemoryInfo = GC.GetGCMemoryInfo();
if (gcMemoryInfo.TotalCommittedBytes > gcMemoryInfo.TotalAvailableMemoryBytes / 2)
{
if (logger.IsVerbose)
logger.LogMessage($"Freeing up memory");

GC.Collect(GC.MaxGeneration, GCCollectionMode.Aggressive);
}

objectWriter.EmitDebugModuleInfo();

succeeded = true;
}
finally
{
if (logger.IsVerbose)
logger.LogMessage($"Finalizing output to '{objectFilePath}'...");

objectWriter.Dispose();

if (!succeeded)
Expand All @@ -1173,6 +1189,9 @@ public static void EmitObject(string objectFilePath, IReadOnlyCollection<Depende
}
}
}

if (logger.IsVerbose)
logger.LogMessage($"Done writing object file");
}

[DllImport(NativeObjectWriterFileName)]
Expand Down