[Codespaces] Fix prebuild by using newer dotnet sdk #83331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to get this msbuild bugfix to resolve a build error during Codespaces prebuild: dotnet/msbuild#8531 We generally avoid bumping to a nightly SDK in global.json since it causes pain for contributors so we bump only in the Codespaces prebuild script.
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsWe need to get this msbuild bugfix to resolve a build error during Codespaces prebuild: dotnet/msbuild#8531 We generally try to avoid bumping to a nightly SDK in global.json since it causes pain for contributors so we bump only in the Codespaces prebuild script. The only downside is that it'll show global.json as modified in git and you need to avoid staging/committing that diff. I think that is an acceptable downside for the next ~1.5 months.
|
ilonatommy
approved these changes
Mar 15, 2023
akoeplinger
added a commit
that referenced
this pull request
Apr 14, 2023
lewing
added a commit
that referenced
this pull request
Apr 15, 2023
* Update dependencies from https://github.com/dotnet/arcade build 20230411.8 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23210.3 -> To Version 8.0.0-beta.23211.8 * Mark NativeBuild_WithDeployOnBuild_UsedByVS as an active issue * Revert codespaces workaround from #83331 * Bring in missing arcade changes * Update dependencies from .NET Eng - Latest manually * Update Version.Details.xml * Update Versions.props * Update dependencies from https://github.com/dotnet/arcade build 20230413.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23210.3 -> To Version 8.0.0-beta.23213.1 * Fix ILCompiler build with newer SDK --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Larry Ewing <[email protected]> Co-authored-by: Alexander Köplinger <[email protected]> Co-authored-by: Viktor Hofer <[email protected]> Co-authored-by: Sven Boemer <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to get this msbuild bugfix to resolve a build error during Codespaces prebuild: dotnet/msbuild#8531
We generally try to avoid bumping to a nightly SDK in global.json since it causes pain for contributors so we bump only in the Codespaces prebuild script.
The only downside is that it'll show global.json as modified in git and you need to avoid staging/committing that diff. I think that is an acceptable downside for the next ~1.5 months.