Skip to content

Adding support for Vector512 bitwise operations: And, AndNot, Or, OnesComplement, and Xor #83354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannergooding merged 7 commits into from
Mar 16, 2023
Merged

Adding support for Vector512 bitwise operations: And, AndNot, Or, OnesComplement, and Xor #83354

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d25304a
Adding support for Vector512 bitwise operations: And, AndNot, Or, One…
tannergooding Mar 13, 2023
4b82857
Adding AVX512F APIs for And, AndNot, Load, Or, Store, and Xor
tannergooding Mar 13, 2023
45fc653
Fix the "throw new PlatformNotSupported" expressions for Avx512F
tannergooding Mar 13, 2023
f57b162
Fixing some test build failures
tannergooding Mar 13, 2023
7cb6fe3
Ensure the Avx512F and related classes can lightup in import
tannergooding Mar 13, 2023
f509157
Ensure that JitStressEvexEncoding is only checked in debug
tannergooding Mar 13, 2023
0fbec21
Allow 64-bit alignment in the test data table types and fix the AVX51…
tannergooding Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ensure that JitStressEvexEncoding is only checked in debug
  • Loading branch information
@tannergooding
tannergooding committed Mar 16, 2023
commit f5091575fed0a8159ddb438d8f2863445e88ca36
11 changes: 9 additions & 2 deletions src/coreclr/jit/compiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2287,6 +2287,7 @@ void Compiler::compSetProcessor()
instructionSetFlags.HasInstructionSet(InstructionSet_AVX512BW) &&
instructionSetFlags.HasInstructionSet(InstructionSet_AVX512DQ))
{
#if defined(DEBUG)
// Using JitStressEVEXEncoding flag will force instructions which would
// otherwise use VEX encoding but can be EVEX encoded to use EVEX encoding
// This requires AVX512VL support. JitForceEVEXEncoding forces this encoding, thus
Expand All @@ -2295,8 +2296,14 @@ void Compiler::compSetProcessor()
// We can't use !DoJitStressEvexEncoding() yet because opts.compSupportsISA hasn't
// been set yet as that's what we're trying to set here

if (!JitConfig.JitForceEVEXEncoding() && !JitConfig.JitStressEvexEncoding() &&
!instructionSetFlags.HasInstructionSet(InstructionSet_AVX512F_VL))
bool disableAvx512 = !JitConfig.JitForceEVEXEncoding() && !JitConfig.JitStressEvexEncoding() &&
!instructionSetFlags.HasInstructionSet(InstructionSet_AVX512F_VL);
#else
// TODO-XARCH-AVX512: Allow AVX512 support by default
bool disableAvx512 = true;
#endif // DEBUG

if (disableAvx512)
{
instructionSetFlags.RemoveInstructionSet(InstructionSet_AVX512F);
instructionSetFlags.RemoveInstructionSet(InstructionSet_AVX512F_VL);
Expand Down