Skip to content

Conversation

@MichalStrehovsky
Copy link
Member

*Shakes fist

[2023/03/15 03:02:43][INFO]   ILC: Memory stats: 2432028672 bytes committed, 8201363456 bytes available
[2023/03/15 03:02:43][INFO]   ILC: Freeing up memory
[2023/03/15 03:02:43][INFO]   ILC: Finalizing output to '/home/helixbot/work/BC8009E1/w/B673099E/e/artifacts/obj/BenchmarkDotNet.Autogenerated/Release/net8.0/linux-x64/native/b5205490-d417-4d0c-89a2-7ce325183843.o'...
[2023/03/15 03:02:43][INFO]   <unknown>:0: error: Undefined temporary symbol
[2023/03/15 03:02:43][INFO] EXEC : error : AggressiveGC requires setting the compacting parameter to true. (Parameter 'compacting') [/home/helixbot/work/BC8009E1/w/B673099E/e/artifacts/bin/MicroBenchmarks/Release/net8.0/b5205490-d417-4d0c-89a2-7ce325183843/BenchmarkDotNet.Autogenerated.csproj]
[2023/03/15 03:02:43][INFO]   System.ArgumentException: AggressiveGC requires setting the compacting parameter to true. (Parameter 'compacting')
[2023/03/15 03:02:43][INFO]      at System.GC.Collect(Int32, GCCollectionMode, Boolean, Boolean) + 0x152
[2023/03/15 03:02:43][INFO]      at ILCompiler.DependencyAnalysis.ObjectWriter.EmitObject(String, IReadOnlyCollection`1, NodeFactory, ObjectWritingOptions, IObjectDumper, Logger) + 0xa06
[2023/03/15 03:02:43][INFO]      at ILCompiler.Compilation.ILCompiler.ICompilation.Compile(String, ObjectDumper) + 0x32
[2023/03/15 03:02:43][INFO]      at ILCompiler.Program.Run() + 0x1aaa

Cc @dotnet/ilc-contrib

@ghost
Copy link

ghost commented Mar 15, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

*Shakes fist

[2023/03/15 03:02:43][INFO]   ILC: Memory stats: 2432028672 bytes committed, 8201363456 bytes available
[2023/03/15 03:02:43][INFO]   ILC: Freeing up memory
[2023/03/15 03:02:43][INFO]   ILC: Finalizing output to '/home/helixbot/work/BC8009E1/w/B673099E/e/artifacts/obj/BenchmarkDotNet.Autogenerated/Release/net8.0/linux-x64/native/b5205490-d417-4d0c-89a2-7ce325183843.o'...
[2023/03/15 03:02:43][INFO]   <unknown>:0: error: Undefined temporary symbol
[2023/03/15 03:02:43][INFO] EXEC : error : AggressiveGC requires setting the compacting parameter to true. (Parameter 'compacting') [/home/helixbot/work/BC8009E1/w/B673099E/e/artifacts/bin/MicroBenchmarks/Release/net8.0/b5205490-d417-4d0c-89a2-7ce325183843/BenchmarkDotNet.Autogenerated.csproj]
[2023/03/15 03:02:43][INFO]   System.ArgumentException: AggressiveGC requires setting the compacting parameter to true. (Parameter 'compacting')
[2023/03/15 03:02:43][INFO]      at System.GC.Collect(Int32, GCCollectionMode, Boolean, Boolean) + 0x152
[2023/03/15 03:02:43][INFO]      at ILCompiler.DependencyAnalysis.ObjectWriter.EmitObject(String, IReadOnlyCollection`1, NodeFactory, ObjectWritingOptions, IObjectDumper, Logger) + 0xa06
[2023/03/15 03:02:43][INFO]      at ILCompiler.Compilation.ILCompiler.ICompilation.Compile(String, ObjectDumper) + 0x32
[2023/03/15 03:02:43][INFO]      at ILCompiler.Program.Run() + 0x1aaa

Cc @dotnet/ilc-contrib

Author: MichalStrehovsky
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

@MichalStrehovsky
Copy link
Member Author

Cc @Maoni0 - could we make this overload not fail like this? This was throwing about an argument that I didn't even specify because I'm not calling that overload. (This was calling Collect(Int32, GCCollectionMode, Boolean) that doesn't even have the compacting parameter.)

@jkotas jkotas merged commit a42f39b into main Mar 15, 2023
@jkotas jkotas deleted the MichalStrehovsky-patch-1 branch March 15, 2023 14:43
@Maoni0
Copy link
Member

Maoni0 commented Mar 15, 2023

that seems totally reasonable. @cshung could we just make those parameters true when aggressive mode is specified?

@ghost ghost locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants