Skip to content

Re-order some blocks in runtimelookup #83453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EgorBo wants to merge 8 commits into from
Closed

Re-order some blocks in runtimelookup #83453

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8894243
Re-order some blocks in runtimelookup
EgorBo Mar 15, 2023
65a2e0b
Update runtimelookup.cpp
EgorBo Mar 15, 2023
05293dc
Update runtimelookup.cpp
EgorBo Mar 15, 2023
61b02a5
Merge branch 'main' of github.com:dotnet/runtime into runtimelookup-r…
EgorBo Mar 21, 2023
4f2b996
Merge branch 'main' of github.com:dotnet/runtime into runtimelookup-r…
EgorBo Mar 28, 2023
9311a11
mark blocks cold
EgorBo Mar 29, 2023
73b458b
Restore fgReorderBlocks
EgorBo Mar 29, 2023
2505631
actually we don't need them, let's rely on OptimizeLayout phase
EgorBo Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update runtimelookup.cpp
  • Loading branch information
@EgorBo
EgorBo authored Mar 15, 2023
commit 05293dc3903fe7ab46594d35b98f9e70b3ef1422
8 changes: 4 additions & 4 deletions src/coreclr/jit/runtimelookup.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,8 @@ PhaseStatus Compiler::fgExpandRuntimeLookups()
// ...
//
// nullcheckBb(BBJ_COND): [weight: 1.0]
// if (*fastPathValue == null)
// goto fallbackBb;
// if (*fastPathValue != null)
// goto fastPathBb;
//
// fallbackBb(BBJ_ALWAYS): [weight: 0.2]
// rtLookupLcl = HelperCall();
Expand Down Expand Up @@ -284,8 +284,8 @@ PhaseStatus Compiler::fgExpandRuntimeLookups()
// ...
//
// nullcheckBb(BBJ_COND): [weight: 0.8]
// if (*fastPathValue == null)
// goto fallbackBb;
// if (*fastPathValue != null)
// goto fastPathBb;
//
// fallbackBb(BBJ_ALWAYS): [weight: 0.36]
// rtLookupLcl = HelperCall();
Expand Down