Skip to content

Update xarch to track more instruction metadata as flags #83473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannergooding merged 11 commits into from
Mar 19, 2023
Merged

Update xarch to track more instruction metadata as flags #83473

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
69f4c8b
Reorder entries in instrsxarch to make finding SIMD instructions easier
tannergooding Mar 15, 2023
612b925
Remove unused instructions: cvtpd2pi, cvtpi2pd, cvtpi2ps, cvtps2pi, c…
tannergooding Mar 15, 2023
4ca9ca9
Updating the xarch SIMD instructions to track flags indicating REX.W …
tannergooding Mar 15, 2023
f6459ad
Update the emitter to take advantage of the new insFlags
tannergooding Mar 15, 2023
edd3ddd
Ensure TakesRexWPrefix works on x86
tannergooding Mar 17, 2023
11da642
Properly track REX.W encoding for VEX vs EVEX
tannergooding Mar 18, 2023
f3fe4f8
Ensure supportsVEX is set before supportsEVEX
tannergooding Mar 18, 2023
5453487
Ensure canUseVexEncoding is true when ForceEVEXEncoding is set
tannergooding Mar 18, 2023
49ac243
Track how some special EVEX instructions are handled differently
tannergooding Mar 18, 2023
f83155a
Apply formatting patch
tannergooding Mar 19, 2023
e315a28
Ensure REX.WX is handled for EVEX where required
tannergooding Mar 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ensure TakesRexWPrefix works on x86
  • Loading branch information
@tannergooding
tannergooding committed Mar 17, 2023
commit edd3ddd65887f5368b228620e49233136fc6cf64
7 changes: 7 additions & 0 deletions src/coreclr/jit/emitxarch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1178,6 +1178,13 @@ emitter::code_t emitter::AddVexPrefix(instruction ins, code_t code, emitAttr att
// Returns true if this instruction, for the given EA_SIZE(attr), will require a REX.W prefix
bool emitter::TakesRexWPrefix(const instrDesc* id) const
{
#if defined(TARGET_X86)
if (!UseVEXEncoding())
{
return false;
}
#endif // TARGET_X86

instruction ins = id->idIns();
emitAttr attr = id->idOpSize();

Expand Down